Add TimeoutConnector decorator #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM 👍 |
clue
changed the title
Contributor
Author
This is now ready for review |
WyriHaximus
approved these changes
Nov 15, 2016
Contributor
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
Awesome, this is a really useful decorator 👍
cboden
approved these changes
Nov 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses promise cancellation to cancel pending connection attempts after the timer expired.
This means the exposed interface should already work, but the underlying socket resources will not currently be cleaned up in time. As such, it probably makes sense to postpone this until #40 is in. Hence marking this as WIP for now.Edit: See #71Closes #28, supersedes/closes #10