[RFC] Remove LazyPromise #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Aug 25, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
I agree that this class is misleading and have seen this attract some poor code and wrong assumptions in the past. As such, I'd also rather remove this and educate users instead 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've personally never used
LazyPromiseand it seems noone else really does :)This shows exactly 2 usages, 1 in a deprecated library (icicle) and 1 wrong usage (
then()is instantly called which defeats the purpose if the lazy promise).