Skip to content

Conditionally require functions.php #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cboden merged 1 commit into from
Dec 7, 2014
Merged

Conditionally require functions.php #25

cboden merged 1 commit into from
Dec 7, 2014

Conversation

@jsor
Copy link
Member

@jsor jsor commented Dec 3, 2014

This allows a global version of React\Promise alongside a local version.

Fixes #23

@jsor
Conditionally require functions.php
586f208 
This allows a global version of React\Promise alongside a local version.

Closes #23
@clue
Copy link
Member

clue commented Dec 5, 2014

LGTM 👍

For the reference: This actually works around an issue in how Composer handles the files directive for global packages (composer/composer#3003). We need to provide this patch until the linked issue has been resolved. We hope to roll this back once this issue has been resolved, so we've looked into providing the most minimal change to our code base.

@igorw
Copy link
Contributor

igorw commented Dec 5, 2014

Up the priority on the composer issue, this potentially affects many packages.

cboden added a commit that referenced this pull request Dec 7, 2014
@cboden
Merge pull request #25 from reactphp/function-conditional-include
478ba7e 
Conditionally require functions.php
@cboden cboden merged commit 478ba7e into master Dec 7, 2014
@jsor jsor deleted the function-conditional-include branch December 8, 2014 18:29
@cboden cboden added this to the v2.2 milestone Dec 9, 2014
This was referenced Jun 25, 2015
Merged
Merged
Merged
WyriHaximus added a commit to WyriHaximus/TickingPromise that referenced this pull request Jan 8, 2016
@WyriHaximus
Conditionally require functions.php as done by reactphp/promise#25
9a753f4
WyriHaximus added a commit to WyriHaximus/reactphp-child-process-promise that referenced this pull request Jan 8, 2016
@WyriHaximus
Conditionally require functions.php as done by reactphp/promise#25
77a9076
WyriHaximus added a commit to reactphp/filesystem that referenced this pull request Feb 18, 2016
@WyriHaximus
Conditionally require functions.php as done by reactphp/promise#25
d8f0e99
@jsor jsor mentioned this pull request Mar 4, 2017
Closed
@clue clue mentioned this pull request Mar 20, 2019
Merged
@clue clue mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

v2.2

Development

Successfully merging this pull request may close these issues.

Cannot redeclare React\Promise\resolve()

5 participants

@jsor @clue @igorw @cboden