[REACTOS] Merge our bootcd and livecd into an all-in-one ReactOS BootCD by HBelusca · Pull Request #7313 · reactos/reactos

HBelusca · 2024-09-05T20:44:16Z

Purpose & Proposed changes

This new BootCD contains the functionality of both the original bootcd (text-mode 1st-stage installer) and the livecd (that will include the 1st-stage GUI installer later).
Our separate livecd ISOs become obsolete, and this completely removes the need for the so-called "hybridcd" ISO.

Some details:

The "hybridcd" build target is completely removed, since now the new BootCD is basically what we used to call "hybridcd".
The "livecd" build target is kept so far (to minimize the code changes), but internally I start to refer to it as "LiveImage", and is reduced to a minimum.

A minimal non-bootable "liveimg.iso" is built (but currently not included within the BootCD). Its purpose will be to implement the "ReactOS Live" functionality as a RAMDISK. (We currently don't support other file formats apart from ISO and flat disk for a RAMDISK).

The "ReactOS Live" (non-RAMDISK) is implemented by adding to the BootCD file tree the files from the LiveImage. These files add two root directories, "Profiles" and "reactos" (which is the SystemRoot for the non-ramdisk LiveImage).
The minimal text-mode ReactOS installation used for the 1st-stage installer, including USETUP itself, and the executable for the 1st-stage GUI installer and the reactos.cab (installation source), are moved to the root directory called "i386" (ideally, one directory per architecture).

The underlying motivation for this, is to ease the manual (or automated) production of bootcds containing more than one of the supported ReactOS architectures.
The "bootcdregtest" target, i.e. the ISOs we feed our testbots with, are left untouched, i.e. they are only constituted of the 1st-stage text-mode installation only, but placed in a per-architecture root directory ("i386", etc. as for the bootcd).
Remove the ACPI APIC/SMP entries from bootcd.ini. They will be made available via the Advanced Boot Options F8 menu in Debug builds, for testing purposes only, in a subsequent commit.

This commit is based upon an older SVN one:
svn path=/branches/setup_improvements/; revision=75273

JIRA issues: CORE-9069, CORE-13525, RELEASE-11

TODOs and considerations for reviewers (please quote a point from below and comment in the PR)

The bootcdregtest ISO needs the same _CD_ARCH_DESTINATION trick (i386, amd64...) as for the bootcd.
~~I accidentally noticed that the GUI setup (at least) seems to work well for installing ROS files by copying them from the livecd tree structure, not just from reactos.cab !~~ Actually, more work needs to be done in this regard, and will be addressed in future commits.
Verify that @learn-more 's JIRA issue CORE-9870 is either fixed or doesn't apply anymore.
The bootcdregtest build target is still present. I think this is the one that is being used for our testbots; however it seems something is still missing: @ColinFinck you've assigned this JIRA report ONLINE-709 to you, could you tell whether it still makes sense?
EDIT: Will be dealt with later (TBD).
Consider disabling the "Install ReactOS" button in the livecd graphical menu, until the 1st-stage GUI installer is fully ready.
Addressed in commit 9c0efba (PR [USERINIT] Hide install option on LiveCD when no installer is available #8614), for RELEASE-8.

jeditobe · 2024-09-06T11:58:08Z

This improvement may affect PXE boot, is not it?

HBelusca · 2024-09-06T13:20:33Z

This improvement may affect PXE boot, is not it?

I don't think so, but if you're able to test PXE boot @jeditobe , I would invite you to give it a try by using one of the available github actions builds from there (maybe a GCC x86 debug build to begin with).

JoachimHenze

Please wait with the merging of this PR until the releases/0.4.15 will have been branched already, which is expected to happen 2024-09-09. The reason for that request is that the current joined .isos size of 431MB (for gcc dbg) is currently bigger than the sum of former livecd and bootcd. I am sure we will improve on that in the future, but until then, let's release with the old thing one more time.

HBelusca · 2024-09-11T20:51:15Z

Please wait with the merging of this PR until the releases/0.4.15 will have been branched already, which is expected to happen 2024-09-09. The reason for that request is that the current joined .isos size of 431MB (for gcc dbg) is currently bigger than the sum of former livecd and bootcd. I am sure we will improve on that in the future, but until then, let's release with the old thing one more time.

For sure I'll wait, and also until I get more feedback and approvals here.

0.4.15 release is now behind us. I've also removed the inclusion of the ramdisk ISO file, so now the size of the proposed boot/livecd is really the sum of former bootcd and livecd.

cbialorucki

Are you still pursuing this @HBelusca? Or are you waiting for GUI setup?

learn-more

I very much like the idea, it would solve a lot of confusion for people when downloading it the first time.

As long as unattend.inf keeps working, let's go.

…CD (#7313) RELEASE-11 It contains the functionality of both the original bootcd (text-mode 1st-stage installer) and the livecd (that will include the 1st-stage GUI installer later). Our separate livecd ISOs become obsolete, and this completely removes the need for the so-called "hybridcd" ISO. Some details: - The "hybridcd" build target is completely removed, since now the new BootCD *is* basically what we used to call "hybridcd". - The "livecd" build target is kept so far (to minimize the code changes), but internally I start to refer to it as "LiveImage", and is reduced to a minimum. A minimal non-bootable "liveimg.iso" is built (but currently not included within the BootCD). Its purpose will be to implement the "ReactOS Live" functionality as a RAMDISK. (We currently don't support other file formats apart from ISO and flat disk for a RAMDISK). The "ReactOS Live" (non-RAMDISK) is implemented by adding to the BootCD file tree the files from the LiveImage. These files add two root directories, "Profiles" and "reactos" (which is the SystemRoot for the non-ramdisk LiveImage). - The minimal text-mode ReactOS installation used for the 1st-stage installer, including USETUP itself, and the executable for the 1st-stage GUI installer and the reactos.cab (installation source), are moved to the root directory called "i386" (ideally, one directory per architecture). - The "bootcdregtest" target, i.e. the ISOs we feed our testbots with, are left untouched, i.e. they are only constituted of the 1st-stage text-mode installation, in the root directory named "reactos". - Remove the ACPI APIC/SMP entries from bootcd.ini. They will be made available via the Advanced Boot Options F8 menu in Debug builds, for testing purposes only, in a subsequent commit. This commit is based upon an older SVN one: svn path=/branches/setup_improvements/; revision=75273

…CD (#7313) CORE-9069, CORE-13525, RELEASE-11 This new BootCD contains the functionality of both the original bootcd (text-mode 1st-stage installer) and the livecd (that will include the 1st-stage GUI installer later). Our separate livecd ISOs become obsolete, and this completely removes the need for the so-called "hybridcd" ISO. Some details: - The "hybridcd" build target is completely removed, since now the new BootCD *is* basically what we used to call "hybridcd". - The "livecd" build target is kept so far (to minimize the code changes), but internally I start to refer to it as "LiveImage", and is reduced to a minimum. A minimal non-bootable "liveimg.iso" is built (but currently not included within the BootCD). Its purpose will be to implement the "ReactOS Live" functionality as a RAMDISK. (We currently don't support other file formats apart from ISO and flat disk for a RAMDISK). The "ReactOS Live" (non-RAMDISK) is implemented by adding to the BootCD file tree the files from the LiveImage. These files add two root directories, "Profiles" and "reactos" (which is the SystemRoot for the non-ramdisk LiveImage). - The minimal text-mode ReactOS installation used for the 1st-stage installer, including USETUP itself, and the executable for the 1st-stage GUI installer and the reactos.cab (installation source), are moved to the root directory called "i386" (ideally, one directory per architecture). - The "bootcdregtest" target, i.e. the ISOs we feed our testbots with, are left untouched, i.e. they are only constituted of the 1st-stage text-mode installation only, but placed in a per-architecture root directory ("i386", etc. as for the bootcd). - Remove the ACPI APIC/SMP entries from bootcd.ini. They will be made available via the Advanced Boot Options F8 menu in Debug builds, for testing purposes only, in a subsequent commit. This commit is based upon an older SVN one: svn path=/branches/setup_improvements/; revision=75273

…s where TXTSETUP.SIF can be found And slightly improve the search loop. - Unconditionally look into the root directory as well, in order to cover all possible boot disk layouts in case someone customizes the ReactOS boot media layout. - Improve the `InfOpenFile()` call error handling, in order to show the erroneous line _iff_ the call failed because of a wrong syntax in TXTSETUP.SIF . Distinguish it from a failure because the file doesn't exist in the source path being tested (in which case, no error is shown).

…CD (#7313) CORE-9069, CORE-13525, RELEASE-11 This new BootCD contains the functionality of both the original bootcd (text-mode 1st-stage installer) and the livecd (that will include the 1st-stage GUI installer later). Our separate livecd ISOs become obsolete, and this completely removes the need for the so-called "hybridcd" ISO. Some details: - The "hybridcd" build target is completely removed, since now the new BootCD *is* basically what we used to call "hybridcd". - The "livecd" build target is kept so far (to minimize the code changes), but internally I start to refer to it as "LiveImage", and is reduced to a minimum. A minimal non-bootable "liveimg.iso" is built (but currently not included within the BootCD). Its purpose will be to implement the "ReactOS Live" functionality as a RAMDISK. (We currently don't support other file formats apart from ISO and flat disk for a RAMDISK). The "ReactOS Live" (non-RAMDISK) is implemented by adding to the BootCD file tree the files from the LiveImage. These files add two root directories, "Profiles" and "reactos" (which is the SystemRoot for the non-ramdisk LiveImage). - The minimal text-mode ReactOS installation used for the 1st-stage installer, including USETUP itself, and the executable for the 1st-stage GUI installer and the reactos.cab (installation source), are moved to the root directory called "i386" (ideally, one directory per architecture). - The "bootcdregtest" target, i.e. the ISOs we feed our testbots with, are left untouched, i.e. they are only constituted of the 1st-stage text-mode installation only, but placed in a per-architecture root directory ("i386", etc. as for the bootcd). - Remove the ACPI APIC/SMP entries from bootcd.ini. They will be made available via the Advanced Boot Options F8 menu in Debug builds, for testing purposes only, in a subsequent commit. This commit is based upon an older SVN one: svn path=/branches/setup_improvements/; revision=75273

Addendum to commit b2e33f2 (PR #7313)

…CD (reactos#7313) CORE-9069, CORE-13525, RELEASE-11 This new BootCD contains the functionality of both the original bootcd (text-mode 1st-stage installer) and the livecd (that will include the 1st-stage GUI installer later). Our separate livecd ISOs become obsolete, and this completely removes the need for the so-called "hybridcd" ISO. Some details: - The "hybridcd" build target is completely removed, since now the new BootCD *is* basically what we used to call "hybridcd". - The "livecd" build target is kept so far (to minimize the code changes), but internally I start to refer to it as "LiveImage", and is reduced to a minimum. A minimal non-bootable "liveimg.iso" is built (but currently not included within the BootCD). Its purpose will be to implement the "ReactOS Live" functionality as a RAMDISK. (We currently don't support other file formats apart from ISO and flat disk for a RAMDISK). The "ReactOS Live" (non-RAMDISK) is implemented by adding to the BootCD file tree the files from the LiveImage. These files add two root directories, "Profiles" and "reactos" (which is the SystemRoot for the non-ramdisk LiveImage). - The minimal text-mode ReactOS installation used for the 1st-stage installer, including USETUP itself, and the executable for the 1st-stage GUI installer and the reactos.cab (installation source), are moved to the root directory called "i386" (ideally, one directory per architecture). - The "bootcdregtest" target, i.e. the ISOs we feed our testbots with, are left untouched, i.e. they are only constituted of the 1st-stage text-mode installation only, but placed in a per-architecture root directory ("i386", etc. as for the bootcd). - Remove the ACPI APIC/SMP entries from bootcd.ini. They will be made available via the Advanced Boot Options F8 menu in Debug builds, for testing purposes only, in a subsequent commit. This commit is based upon an older SVN one: svn path=/branches/setup_improvements/; revision=75273

Addendum to commit b2e33f2 (PR reactos#7313)

Addendum to commit b2e33f2 (PR #7313) This is a cherry-pick of 8fa6679.

…CD (reactos#7313) CORE-9069, CORE-13525, RELEASE-11 This new BootCD contains the functionality of both the original bootcd (text-mode 1st-stage installer) and the livecd (that will include the 1st-stage GUI installer later). Our separate livecd ISOs become obsolete, and this completely removes the need for the so-called "hybridcd" ISO. Some details: - The "hybridcd" build target is completely removed, since now the new BootCD *is* basically what we used to call "hybridcd". - The "livecd" build target is kept so far (to minimize the code changes), but internally I start to refer to it as "LiveImage", and is reduced to a minimum. A minimal non-bootable "liveimg.iso" is built (but currently not included within the BootCD). Its purpose will be to implement the "ReactOS Live" functionality as a RAMDISK. (We currently don't support other file formats apart from ISO and flat disk for a RAMDISK). The "ReactOS Live" (non-RAMDISK) is implemented by adding to the BootCD file tree the files from the LiveImage. These files add two root directories, "Profiles" and "reactos" (which is the SystemRoot for the non-ramdisk LiveImage). - The minimal text-mode ReactOS installation used for the 1st-stage installer, including USETUP itself, and the executable for the 1st-stage GUI installer and the reactos.cab (installation source), are moved to the root directory called "i386" (ideally, one directory per architecture). - The "bootcdregtest" target, i.e. the ISOs we feed our testbots with, are left untouched, i.e. they are only constituted of the 1st-stage text-mode installation only, but placed in a per-architecture root directory ("i386", etc. as for the bootcd). - Remove the ACPI APIC/SMP entries from bootcd.ini. They will be made available via the Advanced Boot Options F8 menu in Debug builds, for testing purposes only, in a subsequent commit. This commit is based upon an older SVN one: svn path=/branches/setup_improvements/; revision=75273

Addendum to commit b2e33f2 (PR reactos#7313)

HBelusca added enhancement For PRs with an enhancement/new feature. review pending For PRs undergoing review. refactoring For refactoring changes. 1st stage GUI setup labels Sep 5, 2024

HBelusca requested review from AmineKhaldi, ColinFinck, DarkFire01, Doug-Lyons, Extravert-ir, GeoB99, JoachimHenze, binarymaster, cbialorucki, hpoussin, katahiromz, learn-more, oleg-dubinskiy, tkreuzer and whindsaks September 5, 2024 20:44

HBelusca self-assigned this Sep 5, 2024

github-actions Bot added the freeldr Freeloader changes label Sep 5, 2024

oleg-dubinskiy reviewed Sep 5, 2024

View reviewed changes

Comment thread boot/bootdata/txtsetup.sif

Comment thread base/setup/welcome/CMakeLists.txt Outdated

oleg-dubinskiy reviewed Sep 5, 2024

View reviewed changes

Comment thread boot/bootdata/autorun.inf

Comment thread boot/bootdata/bootcd.ini Outdated

JoachimHenze previously requested changes Sep 7, 2024

View reviewed changes

JoachimHenze self-requested a review September 11, 2024 22:02

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch from 071597c to 38b306a Compare September 29, 2024 16:05

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch from 38b306a to 4f6ba29 Compare October 20, 2024 15:03

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch 4 times, most recently from 9a74de3 to 81b3f0a Compare October 24, 2024 12:18

cbialorucki approved these changes Mar 25, 2025

View reviewed changes

HBelusca mentioned this pull request Mar 14, 2026

[LIVECD] fix installation from LiveCD media #8737

Closed

2 tasks

learn-more reviewed Apr 2, 2026

View reviewed changes

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch 4 times, most recently from 0a2e632 to 60d19aa Compare April 16, 2026 21:34

katahiromz approved these changes Apr 26, 2026

View reviewed changes

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch from 60d19aa to e105b3d Compare April 27, 2026 21:24

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch from e105b3d to 01dde6e Compare April 28, 2026 15:01

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch from 01dde6e to 75cf9a2 Compare April 28, 2026 20:16

HBelusca added 2 commits April 28, 2026 23:11

HBelusca force-pushed the hbelusca/all_in_one_bootlivecd branch from 75cf9a2 to b2e33f2 Compare April 28, 2026 21:13

HBelusca merged commit b2e33f2 into master Apr 28, 2026
67 checks passed

HBelusca deleted the hbelusca/all_in_one_bootlivecd branch April 28, 2026 21:15

HBelusca added a commit that referenced this pull request May 7, 2026

[BOOT] Remove last instances of "hybridcd"

8fa6679

Addendum to commit b2e33f2 (PR #7313)

Kreijstal pushed a commit to Kreijstal/reactos that referenced this pull request May 13, 2026

[BOOT] Remove last instances of "hybridcd"

cf500d0

Addendum to commit b2e33f2 (PR reactos#7313)

cbialorucki pushed a commit that referenced this pull request May 22, 2026

[0.4.16][BOOT] Remove last instances of "hybridcd"

c8d0ee7

Addendum to commit b2e33f2 (PR #7313) This is a cherry-pick of 8fa6679.

itcthienkhiem pushed a commit to itcthienkhiem/reactos that referenced this pull request Jun 1, 2026

[BOOT] Remove last instances of "hybridcd"

c696107

Addendum to commit b2e33f2 (PR reactos#7313)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[REACTOS] Merge our bootcd and livecd into an all-in-one ReactOS BootCD#7313

[REACTOS] Merge our bootcd and livecd into an all-in-one ReactOS BootCD#7313
HBelusca merged 2 commits into
masterfrom
hbelusca/all_in_one_bootlivecd

HBelusca commented Sep 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeditobe commented Sep 6, 2024 •

edited

Loading

Uh oh!

HBelusca commented Sep 6, 2024

Uh oh!

JoachimHenze left a comment

Uh oh!

HBelusca commented Sep 11, 2024

Uh oh!

cbialorucki left a comment

Uh oh!

learn-more left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

HBelusca commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose & Proposed changes

TODOs and considerations for reviewers (please quote a point from below and comment in the PR)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeditobe commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HBelusca commented Sep 6, 2024

Uh oh!

JoachimHenze left a comment

Choose a reason for hiding this comment

Uh oh!

HBelusca commented Sep 11, 2024

Uh oh!

cbialorucki left a comment

Choose a reason for hiding this comment

Uh oh!

learn-more left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

HBelusca commented Sep 5, 2024 •

edited

Loading

jeditobe commented Sep 6, 2024 •

edited

Loading