Allow setting .pendingAcquireMaxCount() to zero in ConnectionProvider
#3987
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violetagg
requested changes
Oct 28, 2025
Member
violetagg
left a comment
violetagg
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I added some suggestions for more clarity.
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
violetagg
reviewed
Oct 28, 2025
reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java
Outdated
Show resolved
Hide resolved
Fixes reactor#3986. Signed-off-by: Martin7-1 <[email protected]>
Martin7-1
force-pushed
the
set-pendingAcquireMaxCount-zero
branch
from
5b60464 to
47e23bc
Compare
violetagg
approved these changes
Oct 28, 2025
violetagg
added a commit
that referenced
this pull request
Oct 28, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3986.
I'm new to
reactor-netty. I created thisPR as described in CONTRIBUTING.md, please let me know if there is something wrong