Add the HTTP/2 connection to the channel group for a proper graceful shutdown in case no active streams
#3827
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shutdown in case no active streams When shutting down the server and there are active streams, the HTTP/2 connection will be properly closed, however when there are no active stream, the connection is closed with RST which is not correct. Adding the connection to the channel group will close the connection with a correct GO_AWAY. Signed-off-by: Violeta Georgieva <[email protected]>
violetagg
added a commit
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
violetagg
added a commit
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutting down the server and there are active streams, the
HTTP/2connection will be properly closed,however when there are no active stream, the connection is closed with
RSTwhich is not correct. Adding the connection to the channel group will close the connection with a correctGO_AWAY.Fixes #3828