Add request and response header iterators to AccessLogArgProvider
#3735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `requestHeaderIterator` and `responseHeaderIterator` methods for iterating through headers in `AccessLogArgProvider` and its implementations. Updated relevant tests to verify header iteration functionality. Related to reactor#781 Signed-off-by: Dmitry Sulman <[email protected]>
Signed-off-by: Dmitry Sulman <[email protected]>
Signed-off-by: Dmitry Sulman <[email protected]>
violetagg
approved these changes
Apr 28, 2025
Member
violetagg
left a comment
violetagg
left a comment
There was a problem hiding this comment.
@dmitrysulman Thanks for the PR!
violetagg
added a commit
that referenced
this pull request
Apr 28, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
violetagg
added a commit
that referenced
this pull request
Apr 28, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
requestHeaderIteratorandresponseHeaderIteratormethods for iterating through headers inAccessLogArgProviderand its implementations.Related to #781 (comment)