Skip to content

Enable set up TcpResources default max connection by setting #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
violetagg merged 2 commits into from
Apr 10, 2025
Merged

Enable set up TcpResources default max connection by setting #3712

violetagg merged 2 commits into from
Apr 10, 2025

Conversation

@lcamhoa
Copy link
Contributor

@lcamhoa lcamhoa commented Apr 10, 2025

The max connection is set up 500 by default. It's hard to optimize it .

@violetagg
Copy link
Member

violetagg commented Apr 10, 2025

@lcamhoa Please add Signed-off-by to the commit. See https://github.com/reactor/.github/blob/main/CONTRIBUTING.md#clipboard-developer-certificate-of-origin

Which version do you need to include this enhancement (1.1.x, 1.2.x or the future 1.3.x aka main branch)? The main branch is the current development for the version that will be released in November.

@violetagg violetagg added the type/enhancement A general enhancement label Apr 10, 2025
@lcamhoa
Copy link
Contributor Author

lcamhoa commented Apr 10, 2025

@lcamhoa Please add Signed-off-by to the commit. See https://github.com/reactor/.github/blob/main/CONTRIBUTING.md#clipboard-developer-certificate-of-origin

Which version do you need to include this enhancement (1.1.x, 1.2.x or the future 1.3.x aka main branch)? The main branch is the current development for the version that will be released in November.

Thank you for feedback . main is good for me.

@violetagg violetagg added this to the 1.3.0-M2 milestone Apr 10, 2025
@violetagg
Copy link
Member

violetagg commented Apr 10, 2025

@lcamhoa You need to add Signed-off-by to every commit

@lcamhoa
Copy link
Contributor Author

lcamhoa commented Apr 10, 2025

@violetagg I did it . Please check again.

@violetagg
Copy link
Member

violetagg commented Apr 10, 2025

DCO is failing with this https://github.com/reactor/reactor-netty/pull/3712/checks?check_run_id=40300741452

Hoa Lam and others added 2 commits April 10, 2025 13:15
@lcamhoa
Copy link
Contributor Author

lcamhoa commented Apr 10, 2025

DCO is failing with this https://github.com/reactor/reactor-netty/pull/3712/checks?check_run_id=40300741452

I did it again. Thank for sharing the fail job link

violetagg
violetagg approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@violetagg violetagg changed the title Enable set up TPC Resource default max connection by setting. Enable set up TcpResources default max connection by setting Apr 10, 2025
@violetagg violetagg merged commit 4139b23 into reactor:main Apr 10, 2025
14 checks passed
violetagg added a commit that referenced this pull request Apr 10, 2025
@violetagg
Merge #3712 into 2.0.0-M4
5bf1091 
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@violetagg violetagg violetagg approved these changes

Assignees

No one assigned

Labels

type/enhancement A general enhancement

Projects

None yet

Milestone

1.3.0-M2

Development

Successfully merging this pull request may close these issues.

2 participants

@lcamhoa @violetagg