Add API for determining the resolved addresses to which this client should connect #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould connect Signed-off-by: Violeta Georgieva <[email protected]>
chemicL
approved these changes
Mar 19, 2025
Member
chemicL
left a comment
chemicL
left a comment
There was a problem hiding this comment.
LGTM, just left two questions.
reactor-netty-core/src/main/java/reactor/netty/transport/ClientTransportConfig.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/transport/TransportConnector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Violeta Georgieva <[email protected]>
chemicL
approved these changes
Mar 19, 2025
rstoyanchev
reviewed
Mar 24, 2025
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
Looks good. Possibly the BiFunction could be a an interface, which can document expectations of implementations and also makes it discoverable.
Signed-off-by: Violeta Georgieva <[email protected]>
Member
Author
|
@chemicL @rstoyanchev I extracted the |
Signed-off-by: Violeta Georgieva <[email protected]>
Member
Author
|
Let me merge this one. We can follow up if needed. |
violetagg
added a commit
that referenced
this pull request
Mar 27, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
violetagg
added a commit
that referenced
this pull request
Mar 27, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.