Skip to content

Add HttpMeterRegistrarAdapter to track active streams in HTTP/2 and HTTP/3 #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
violetagg merged 15 commits into from
Feb 21, 2025
Merged

Add HttpMeterRegistrarAdapter to track active streams in HTTP/2 and HTTP/3 #3632

violetagg merged 15 commits into from
Feb 21, 2025

Conversation

@raccoonback
Copy link
Contributor

@raccoonback raccoonback commented Feb 16, 2025

Description

This PR introduces Http2MeterRegistrarAdapter to provide metrics for HTTP/2 active and pending stream counts. By integrating this, users can monitor the number of active and pending streams in HTTP/2 connections.

Changes

  • Added Http2MeterRegistrarAdapter to track active and pending streams count.
  • Integrated the new registrar with the existing metrics system.
  • Provided test cases to validate the metrics collection.

Related Issues

@raccoonback raccoonback marked this pull request as ready for review February 16, 2025 03:42
raccoonback
raccoonback commented Feb 16, 2025
View reviewed changes
@violetagg
Copy link
Member

violetagg commented Feb 16, 2025

@raccoonback Can you please rebase on top of 1.2.x branch and then change the target branch?

@violetagg violetagg added the type/enhancement A general enhancement label Feb 16, 2025
@violetagg violetagg added this to the 1.2.4 milestone Feb 16, 2025
@raccoonback raccoonback changed the base branch from main to 1.2.x February 16, 2025 10:16
@raccoonback
Provides Http2MeterRegistrarAdapter to aggregate the count of active …
b0c5429 
…and pending streams in the HTTP/2 protocol

Signed-off-by: raccoonback <[email protected]>
@raccoonback
Add test for Http2MeterRegistrarAdapter
32f3e88 
Signed-off-by: raccoonback <[email protected]>
@raccoonback
Add author comment
7d36af5 
Signed-off-by: raccoonback <[email protected]>
@raccoonback
Fix checkstyle
a5dcbdd 
Signed-off-by: raccoonback <[email protected]>
@raccoonback
Copy link
Contributor Author

raccoonback commented Feb 16, 2025

@violetagg
Hello!
I have rebased the branch onto 1.2.x and changed the target branch of the PR to 1.2.x.

@violetagg violetagg self-requested a review February 17, 2025 15:25
@violetagg
Copy link
Member

violetagg commented Feb 17, 2025

@raccoonback I'll review this PR later this week

violetagg
violetagg requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raccoonback Thanks for the PR!
Please check my comments.
For the test I would recommend to extend the BaseHttpTest and to reuse the methods for creating server/client.

@violetagg violetagg linked an issue Feb 20, 2025 that may be closed by this pull request
Expose activeStreams and potentially pendingStreams for use in ConnectionPoolMetrics in MeterRegistrar #3344
Closed
@raccoonback
Copy link
Contributor Author

raccoonback commented Feb 21, 2025

@violetagg
Thanks for the review!
I have reflected all the comments you mentioned.
Please take a look!

violetagg
violetagg requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are almost ready with this change.

@raccoonback
Copy link
Contributor Author

raccoonback commented Feb 21, 2025

@violetagg
Thank you for the review!
I've reflected everything.

@violetagg violetagg merged commit 14723bb into reactor:1.2.x Feb 21, 2025
14 checks passed
@violetagg violetagg changed the title Add Http2MeterRegistrarAdapter to track active and pending streams in HTTP/2 Add HttpMeterRegistrarAdapter to track active streams in HTTP/2 and HTTP/3 Feb 21, 2025
violetagg added a commit that referenced this pull request Feb 21, 2025
@violetagg
Merge #3632 into 1.3.0-M1
362d30e 
Signed-off-by: Violeta Georgieva <[email protected]>
violetagg added a commit that referenced this pull request Feb 21, 2025
@violetagg
Merge #3632 into 2.0.0-M4
98d2543 
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@violetagg violetagg violetagg approved these changes

Assignees

No one assigned

Labels

type/enhancement A general enhancement

Projects

None yet

Milestone

1.2.4

Development

Successfully merging this pull request may close these issues.

Expose activeStreams and potentially pendingStreams for use in ConnectionPoolMetrics in MeterRegistrar

2 participants

@raccoonback @violetagg