fix" issue with dynamically applied classes not being properly removed for reentering items#499
Merged
Merged
Conversation
taion
approved these changes
May 9, 2019
taion
left a comment
taion
left a comment
Contributor
There was a problem hiding this comment.
cool – this is a good improvement. i made some minor comments for improving code readability a bit, but this is nice
Contributor
Author
|
@taion thanks for the review! I've applied all your suggested code changes |
jquense
approved these changes
May 9, 2019
Contributor
Author
|
No pressure - just a question. Are there chances for a new release with this soon(-ish) or should we use a fork temporarily? |
jquense
changed the title
Contributor
|
aaarrrrg i messed up the commit name. it'll get published once i fix it |
jquense
pushed a commit
that referenced
this pull request
May 9, 2019
…d for reentering items (#499) * Add failing test for not removing dynamically applied classes * Fixed issue with not removing dynamically applied classes * Clear cached applied classes when removing them * Few stylistic changes suggested at code review * Fix linting errors
jquense
pushed a commit
that referenced
this pull request
May 9, 2019
## [4.0.1](v4.0.0...v4.0.1) (2019-05-09) ### Bug Fixes * issue with dynamically applied classes not being properly removed for reentering items ([#499](#499)) ([129cb11](129cb11))
Contributor
Author
|
Thanks for the quick release ❤️ |
johnfrench3
pushed a commit
to johnfrench3/transition-group-react
that referenced
this pull request
Nov 2, 2022
## [4.0.1](reactjs/react-transition-group@v4.0.0...v4.0.1) (2019-05-09) ### Bug Fixes * issue with dynamically applied classes not being properly removed for reentering items ([#499](reactjs/react-transition-group#499)) ([129cb11](reactjs/react-transition-group@129cb11))
patrickm68
added a commit
to patrickm68/react-transition-group-developer
that referenced
this pull request
Dec 1, 2022
## [4.0.1](reactjs/react-transition-group@v4.0.0...v4.0.1) (2019-05-09) ### Bug Fixes * issue with dynamically applied classes not being properly removed for reentering items ([#499](reactjs/react-transition-group#499)) ([129cb11](reactjs/react-transition-group@129cb11))
shaikdev2
pushed a commit
to shaikdev2/transition-group-react
that referenced
this pull request
Jun 9, 2023
## [4.0.1](reactjs/react-transition-group@v4.0.0...v4.0.1) (2019-05-09) ### Bug Fixes * issue with dynamically applied classes not being properly removed for reentering items ([#499](reactjs/react-transition-group#499)) ([129cb11](reactjs/react-transition-group@129cb11))
GreenCat1996
added a commit
to GreenCat1996/react-transition-group
that referenced
this pull request
Aug 1, 2023
## [4.0.1](reactjs/react-transition-group@v4.0.0...v4.0.1) (2019-05-09) ### Bug Fixes * issue with dynamically applied classes not being properly removed for reentering items ([#499](reactjs/react-transition-group#499)) ([129cb11](reactjs/react-transition-group@129cb11))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - https://codesandbox.io/s/zzxzjjwwmp
Notice how the reentered item (foo) has "exit" classes applied incorrectly.