Skip to content

fix: Escape hatches -> 탈출구 #738#783

Merged
hg-pyun merged 1 commit intomainfrom
fix/escape-hatches
Oct 3, 2023
Merged

fix: Escape hatches -> 탈출구 #738#783
hg-pyun merged 1 commit intomainfrom
fix/escape-hatches

Conversation

@eomttt
Copy link
Copy Markdown
Collaborator

@eomttt eomttt commented Sep 24, 2023

#738

여기서 나온 이슈를 바탕으로 기존에 있던 단어를 수정합니다

@eomttt eomttt self-assigned this Sep 24, 2023
@eomttt eomttt linked an issue Sep 24, 2023 that may be closed by this pull request
용어: Escape Hatches #738
Closed
1 task
@eomttt eomttt changed the title fix: Escape hatches -> 탈출구 [#738] fix: Escape hatches -> 탈출구 Sep 24, 2023
@eomttt eomttt changed the title [#738] fix: Escape hatches -> 탈출구 [#738](https://github.com/reactjs/ko.react.dev/issues/738) fix: Escape hatches -> 탈출구 Sep 24, 2023
@eomttt eomttt changed the title [#738](https://github.com/reactjs/ko.react.dev/issues/738) fix: Escape hatches -> 탈출구 https://github.com/reactjs/ko.react.dev/issues/738 fix: Escape hatches -> 탈출구 Sep 24, 2023
@eomttt eomttt changed the title https://github.com/reactjs/ko.react.dev/issues/738 fix: Escape hatches -> 탈출구 fix: Escape hatches -> 탈출구 #738 Sep 24, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 78.74 KB (🟡 +7 B) 182.69 KB
/500 78.74 KB (🟡 +7 B) 182.69 KB
/[[...markdownPath]] 80.44 KB (🟡 +8 B) 184.38 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

hg-pyun
hg-pyun approved these changes Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun hg-pyun merged commit c043ee5 into main Oct 3, 2023
@hg-pyun hg-pyun deleted the fix/escape-hatches branch October 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno

@simsim0709 simsim0709 Awaiting requested review from simsim0709

@gnujoow gnujoow Awaiting requested review from gnujoow gnujoow is a code owner

@b9words b9words Awaiting requested review from b9words

@taggon taggon Awaiting requested review from taggon

@MaxKim-J MaxKim-J Awaiting requested review from MaxKim-J

Assignees

@eomttt eomttt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

용어: Escape Hatches

2 participants

@eomttt @hg-pyun