conditional rendering page translation#177
Merged
arshadkazmi42 merged 6 commits intoreactjs:mainfrom Jan 17, 2022
Merged
Conversation
arshadkazmi42
requested changes
Jan 16, 2022
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work again.
Added review in the file.
Lets close these, then you can continue with further translations
Member
|
@sanchit36 I have verified the fixes. All looks good. You can continue further with translating the rest of the file |
Contributor
Author
|
@arshadkazmi42 I have completed the page, need your review. |
arshadkazmi42
requested changes
Jan 17, 2022
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
I have added review for rest of the changes.
Once these are fixed. these should be go to be merged
arshadkazmi42
approved these changes
Jan 17, 2022
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work.
Lets get this merged 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translating the conditional rendering page.
Related to #168
Review Progress
? :)&&)? :&&? :toifand variablesI have done till
Conditionally assigning JSX to a variable.