Skip to content

Commit 5d0c812

Browse files
ChrisPulmanChrisPulman
authored
Housekeeping Retire Xamarin (#652)
* Housekeeping Retire Xamarin * Incorrectly place null check
1 parent 4fc5716 commit 5d0c812

37 files changed

+1159
-959
lines changed

‎.editorconfig

+349-5
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,39 @@ root = true
1010
insert_final_newline = true
1111
indent_style = space
1212
indent_size = 4
13+
dotnet_diagnostic.CA1027.severity=error
14+
dotnet_diagnostic.CA1062.severity=error
15+
dotnet_diagnostic.CA1064.severity=error
16+
dotnet_diagnostic.CA1066.severity=error
17+
dotnet_diagnostic.CA1067.severity=error
18+
dotnet_diagnostic.CA1068.severity=error
19+
dotnet_diagnostic.CA1069.severity=warning
20+
dotnet_diagnostic.CA2013.severity=error
21+
dotnet_diagnostic.CA1802.severity=error
22+
dotnet_diagnostic.CA1813.severity=error
23+
dotnet_diagnostic.CA1814.severity=error
24+
dotnet_diagnostic.CA1815.severity=error
25+
dotnet_diagnostic.CA1822.severity=error
26+
dotnet_diagnostic.CA1827.severity=error
27+
dotnet_diagnostic.CA1828.severity=error
28+
dotnet_diagnostic.CA1826.severity=error
29+
dotnet_diagnostic.CA1829.severity=error
30+
dotnet_diagnostic.CA1830.severity=error
31+
dotnet_diagnostic.CA1831.severity=error
32+
dotnet_diagnostic.CA1832.severity=error
33+
dotnet_diagnostic.CA1833.severity=error
34+
dotnet_diagnostic.CA1834.severity=error
35+
dotnet_diagnostic.CA1835.severity=error
36+
dotnet_diagnostic.CA1836.severity=error
37+
dotnet_diagnostic.CA1837.severity=error
38+
dotnet_diagnostic.CA1838.severity=error
39+
dotnet_diagnostic.CA2015.severity=error
40+
dotnet_diagnostic.CA2012.severity=error
41+
dotnet_diagnostic.CA2011.severity=error
42+
dotnet_diagnostic.CA2009.severity=error
43+
dotnet_diagnostic.CA2008.severity=error
44+
dotnet_diagnostic.CA2007.severity=warning
45+
dotnet_diagnostic.CA2000.severity=suggestion
1346

1447
[project.json]
1548
indent_size = 2
@@ -43,14 +76,11 @@ dotnet_style_qualification_for_method = false:suggestion
4376
dotnet_style_qualification_for_event = false:suggestion
4477

4578
# only use var when it's obvious what the variable type is
46-
csharp_style_var_for_built_in_types = false:none
79+
csharp_style_var_for_built_in_types = true:suggestion
4780
csharp_style_var_when_type_is_apparent = true:suggestion
4881
csharp_style_var_elsewhere = true:suggestion
4982

50-
# Types: use keywords instead of BCL types, and permit var only when the type is clear
51-
csharp_style_var_for_built_in_types = false:suggestion
52-
csharp_style_var_when_type_is_apparent = false:none
53-
csharp_style_var_elsewhere = false:suggestion
83+
# prefer C# premade types.
5484
dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
5585
dotnet_style_predefined_type_for_member_access = true:suggestion
5686

@@ -157,6 +187,318 @@ csharp_space_between_method_declaration_parameter_list_parentheses = false
157187
csharp_space_between_parentheses = false
158188
csharp_space_between_square_brackets = false
159189

190+
# analyzers
191+
dotnet_diagnostic.AvoidAsyncVoid.severity = suggestion
192+
193+
dotnet_diagnostic.CA1000.severity = none
194+
dotnet_diagnostic.CA1001.severity = error
195+
dotnet_diagnostic.CA1009.severity = error
196+
dotnet_diagnostic.CA1016.severity = error
197+
dotnet_diagnostic.CA1030.severity = none
198+
dotnet_diagnostic.CA1031.severity = none
199+
dotnet_diagnostic.CA1033.severity = none
200+
dotnet_diagnostic.CA1036.severity = none
201+
dotnet_diagnostic.CA1049.severity = error
202+
dotnet_diagnostic.CA1056.severity = suggestion
203+
dotnet_diagnostic.CA1060.severity = error
204+
dotnet_diagnostic.CA1061.severity = error
205+
dotnet_diagnostic.CA1063.severity = error
206+
dotnet_diagnostic.CA1065.severity = error
207+
dotnet_diagnostic.CA1301.severity = error
208+
dotnet_diagnostic.CA1303.severity = none
209+
dotnet_diagnostic.CA1308.severity = none
210+
dotnet_diagnostic.CA1400.severity = error
211+
dotnet_diagnostic.CA1401.severity = error
212+
dotnet_diagnostic.CA1403.severity = error
213+
dotnet_diagnostic.CA1404.severity = error
214+
dotnet_diagnostic.CA1405.severity = error
215+
dotnet_diagnostic.CA1410.severity = error
216+
dotnet_diagnostic.CA1415.severity = error
217+
dotnet_diagnostic.CA1507.severity = error
218+
dotnet_diagnostic.CA1710.severity = suggestion
219+
dotnet_diagnostic.CA1724.severity = none
220+
dotnet_diagnostic.CA1810.severity = none
221+
dotnet_diagnostic.CA1821.severity = error
222+
dotnet_diagnostic.CA1900.severity = error
223+
dotnet_diagnostic.CA1901.severity = error
224+
dotnet_diagnostic.CA2000.severity = none
225+
dotnet_diagnostic.CA2002.severity = error
226+
dotnet_diagnostic.CA2007.severity = none
227+
dotnet_diagnostic.CA2100.severity = error
228+
dotnet_diagnostic.CA2101.severity = error
229+
dotnet_diagnostic.CA2108.severity = error
230+
dotnet_diagnostic.CA2111.severity = error
231+
dotnet_diagnostic.CA2112.severity = error
232+
dotnet_diagnostic.CA2114.severity = error
233+
dotnet_diagnostic.CA2116.severity = error
234+
dotnet_diagnostic.CA2117.severity = error
235+
dotnet_diagnostic.CA2122.severity = error
236+
dotnet_diagnostic.CA2123.severity = error
237+
dotnet_diagnostic.CA2124.severity = error
238+
dotnet_diagnostic.CA2126.severity = error
239+
dotnet_diagnostic.CA2131.severity = error
240+
dotnet_diagnostic.CA2132.severity = error
241+
dotnet_diagnostic.CA2133.severity = error
242+
dotnet_diagnostic.CA2134.severity = error
243+
dotnet_diagnostic.CA2137.severity = error
244+
dotnet_diagnostic.CA2138.severity = error
245+
dotnet_diagnostic.CA2140.severity = error
246+
dotnet_diagnostic.CA2141.severity = error
247+
dotnet_diagnostic.CA2146.severity = error
248+
dotnet_diagnostic.CA2147.severity = error
249+
dotnet_diagnostic.CA2149.severity = error
250+
dotnet_diagnostic.CA2200.severity = error
251+
dotnet_diagnostic.CA2202.severity = error
252+
dotnet_diagnostic.CA2207.severity = error
253+
dotnet_diagnostic.CA2212.severity = error
254+
dotnet_diagnostic.CA2213.severity = error
255+
dotnet_diagnostic.CA2214.severity = error
256+
dotnet_diagnostic.CA2216.severity = error
257+
dotnet_diagnostic.CA2220.severity = error
258+
dotnet_diagnostic.CA2229.severity = error
259+
dotnet_diagnostic.CA2231.severity = error
260+
dotnet_diagnostic.CA2232.severity = error
261+
dotnet_diagnostic.CA2235.severity = error
262+
dotnet_diagnostic.CA2236.severity = error
263+
dotnet_diagnostic.CA2237.severity = error
264+
dotnet_diagnostic.CA2238.severity = error
265+
dotnet_diagnostic.CA2240.severity = error
266+
dotnet_diagnostic.CA2241.severity = error
267+
dotnet_diagnostic.CA2242.severity = error
268+
269+
dotnet_diagnostic.RCS1001.severity = error
270+
dotnet_diagnostic.RCS1018.severity = error
271+
dotnet_diagnostic.RCS1037.severity = error
272+
dotnet_diagnostic.RCS1055.severity = error
273+
dotnet_diagnostic.RCS1062.severity = error
274+
dotnet_diagnostic.RCS1066.severity = error
275+
dotnet_diagnostic.RCS1069.severity = error
276+
dotnet_diagnostic.RCS1071.severity = error
277+
dotnet_diagnostic.RCS1074.severity = error
278+
dotnet_diagnostic.RCS1090.severity = error
279+
dotnet_diagnostic.RCS1138.severity = error
280+
dotnet_diagnostic.RCS1139.severity = error
281+
dotnet_diagnostic.RCS1163.severity = suggestion
282+
dotnet_diagnostic.RCS1168.severity = suggestion
283+
dotnet_diagnostic.RCS1188.severity = error
284+
dotnet_diagnostic.RCS1201.severity = error
285+
dotnet_diagnostic.RCS1207.severity = error
286+
dotnet_diagnostic.RCS1211.severity = error
287+
dotnet_diagnostic.RCS1507.severity = error
288+
289+
dotnet_diagnostic.SA1000.severity = error
290+
dotnet_diagnostic.SA1001.severity = error
291+
dotnet_diagnostic.SA1002.severity = error
292+
dotnet_diagnostic.SA1003.severity = error
293+
dotnet_diagnostic.SA1004.severity = error
294+
dotnet_diagnostic.SA1005.severity = error
295+
dotnet_diagnostic.SA1006.severity = error
296+
dotnet_diagnostic.SA1007.severity = error
297+
dotnet_diagnostic.SA1008.severity = error
298+
dotnet_diagnostic.SA1009.severity = error
299+
dotnet_diagnostic.SA1010.severity = suggestion
300+
dotnet_diagnostic.SA1011.severity = error
301+
dotnet_diagnostic.SA1012.severity = error
302+
dotnet_diagnostic.SA1013.severity = error
303+
dotnet_diagnostic.SA1014.severity = error
304+
dotnet_diagnostic.SA1015.severity = error
305+
dotnet_diagnostic.SA1016.severity = error
306+
dotnet_diagnostic.SA1017.severity = error
307+
dotnet_diagnostic.SA1018.severity = error
308+
dotnet_diagnostic.SA1019.severity = error
309+
dotnet_diagnostic.SA1020.severity = error
310+
dotnet_diagnostic.SA1021.severity = error
311+
dotnet_diagnostic.SA1022.severity = error
312+
dotnet_diagnostic.SA1023.severity = error
313+
dotnet_diagnostic.SA1024.severity = error
314+
dotnet_diagnostic.SA1025.severity = error
315+
dotnet_diagnostic.SA1026.severity = error
316+
dotnet_diagnostic.SA1027.severity = error
317+
dotnet_diagnostic.SA1028.severity = error
318+
dotnet_diagnostic.SA1100.severity = error
319+
dotnet_diagnostic.SA1101.severity = none
320+
dotnet_diagnostic.SA1102.severity = error
321+
dotnet_diagnostic.SA1103.severity = error
322+
dotnet_diagnostic.SA1104.severity = error
323+
dotnet_diagnostic.SA1105.severity = error
324+
dotnet_diagnostic.SA1106.severity = error
325+
dotnet_diagnostic.SA1107.severity = error
326+
dotnet_diagnostic.SA1108.severity = error
327+
dotnet_diagnostic.SA1110.severity = error
328+
dotnet_diagnostic.SA1111.severity = error
329+
dotnet_diagnostic.SA1112.severity = error
330+
dotnet_diagnostic.SA1113.severity = error
331+
dotnet_diagnostic.SA1114.severity = error
332+
dotnet_diagnostic.SA1115.severity = error
333+
dotnet_diagnostic.SA1116.severity = error
334+
dotnet_diagnostic.SA1117.severity = error
335+
dotnet_diagnostic.SA1118.severity = error
336+
dotnet_diagnostic.SA1119.severity = error
337+
dotnet_diagnostic.SA1120.severity = error
338+
dotnet_diagnostic.SA1121.severity = error
339+
dotnet_diagnostic.SA1122.severity = error
340+
dotnet_diagnostic.SA1123.severity = error
341+
dotnet_diagnostic.SA1124.severity = error
342+
dotnet_diagnostic.SA1125.severity = error
343+
dotnet_diagnostic.SA1127.severity = error
344+
dotnet_diagnostic.SA1128.severity = error
345+
dotnet_diagnostic.SA1129.severity = error
346+
dotnet_diagnostic.SA1130.severity = error
347+
dotnet_diagnostic.SA1131.severity = error
348+
dotnet_diagnostic.SA1132.severity = error
349+
dotnet_diagnostic.SA1133.severity = error
350+
dotnet_diagnostic.SA1134.severity = error
351+
dotnet_diagnostic.SA1135.severity = error
352+
dotnet_diagnostic.SA1136.severity = error
353+
dotnet_diagnostic.SA1137.severity = error
354+
dotnet_diagnostic.SA1139.severity = error
355+
dotnet_diagnostic.SA1200.severity = none
356+
dotnet_diagnostic.SA1201.severity = error
357+
dotnet_diagnostic.SA1202.severity = error
358+
dotnet_diagnostic.SA1203.severity = error
359+
dotnet_diagnostic.SA1204.severity = error
360+
dotnet_diagnostic.SA1205.severity = error
361+
dotnet_diagnostic.SA1206.severity = error
362+
dotnet_diagnostic.SA1207.severity = error
363+
dotnet_diagnostic.SA1208.severity = error
364+
dotnet_diagnostic.SA1209.severity = error
365+
dotnet_diagnostic.SA1210.severity = error
366+
dotnet_diagnostic.SA1211.severity = error
367+
dotnet_diagnostic.SA1212.severity = error
368+
dotnet_diagnostic.SA1213.severity = error
369+
dotnet_diagnostic.SA1214.severity = error
370+
dotnet_diagnostic.SA1216.severity = error
371+
dotnet_diagnostic.SA1217.severity = error
372+
dotnet_diagnostic.SA1300.severity = error
373+
dotnet_diagnostic.SA1302.severity = error
374+
dotnet_diagnostic.SA1303.severity = error
375+
dotnet_diagnostic.SA1304.severity = error
376+
dotnet_diagnostic.SA1306.severity = none
377+
dotnet_diagnostic.SA1307.severity = error
378+
dotnet_diagnostic.SA1308.severity = error
379+
dotnet_diagnostic.SA1309.severity = none
380+
dotnet_diagnostic.SA1310.severity = error
381+
dotnet_diagnostic.SA1311.severity = none
382+
dotnet_diagnostic.SA1312.severity = error
383+
dotnet_diagnostic.SA1313.severity = error
384+
dotnet_diagnostic.SA1314.severity = error
385+
dotnet_diagnostic.SA1316.severity = none
386+
dotnet_diagnostic.SA1400.severity = error
387+
dotnet_diagnostic.SA1401.severity = error
388+
dotnet_diagnostic.SA1402.severity = error
389+
dotnet_diagnostic.SA1403.severity = error
390+
dotnet_diagnostic.SA1404.severity = error
391+
dotnet_diagnostic.SA1405.severity = error
392+
dotnet_diagnostic.SA1406.severity = error
393+
dotnet_diagnostic.SA1407.severity = error
394+
dotnet_diagnostic.SA1408.severity = error
395+
dotnet_diagnostic.SA1410.severity = error
396+
dotnet_diagnostic.SA1411.severity = error
397+
dotnet_diagnostic.SA1413.severity = none
398+
dotnet_diagnostic.SA1500.severity = error
399+
dotnet_diagnostic.SA1501.severity = error
400+
dotnet_diagnostic.SA1502.severity = error
401+
dotnet_diagnostic.SA1503.severity = error
402+
dotnet_diagnostic.SA1504.severity = error
403+
dotnet_diagnostic.SA1505.severity = none
404+
dotnet_diagnostic.SA1506.severity = error
405+
dotnet_diagnostic.SA1507.severity = error
406+
dotnet_diagnostic.SA1508.severity = error
407+
dotnet_diagnostic.SA1509.severity = error
408+
dotnet_diagnostic.SA1510.severity = error
409+
dotnet_diagnostic.SA1511.severity = error
410+
dotnet_diagnostic.SA1512.severity = error
411+
dotnet_diagnostic.SA1513.severity = error
412+
dotnet_diagnostic.SA1514.severity = none
413+
dotnet_diagnostic.SA1515.severity = error
414+
dotnet_diagnostic.SA1516.severity = error
415+
dotnet_diagnostic.SA1517.severity = error
416+
dotnet_diagnostic.SA1518.severity = error
417+
dotnet_diagnostic.SA1519.severity = error
418+
dotnet_diagnostic.SA1520.severity = error
419+
dotnet_diagnostic.SA1600.severity = error
420+
dotnet_diagnostic.SA1601.severity = error
421+
dotnet_diagnostic.SA1602.severity = error
422+
dotnet_diagnostic.SA1604.severity = error
423+
dotnet_diagnostic.SA1605.severity = error
424+
dotnet_diagnostic.SA1606.severity = error
425+
dotnet_diagnostic.SA1607.severity = error
426+
dotnet_diagnostic.SA1608.severity = error
427+
dotnet_diagnostic.SA1610.severity = error
428+
dotnet_diagnostic.SA1611.severity = error
429+
dotnet_diagnostic.SA1612.severity = error
430+
dotnet_diagnostic.SA1613.severity = error
431+
dotnet_diagnostic.SA1614.severity = error
432+
dotnet_diagnostic.SA1615.severity = error
433+
dotnet_diagnostic.SA1616.severity = error
434+
dotnet_diagnostic.SA1617.severity = error
435+
dotnet_diagnostic.SA1618.severity = error
436+
dotnet_diagnostic.SA1619.severity = error
437+
dotnet_diagnostic.SA1620.severity = error
438+
dotnet_diagnostic.SA1621.severity = error
439+
dotnet_diagnostic.SA1622.severity = error
440+
dotnet_diagnostic.SA1623.severity = error
441+
dotnet_diagnostic.SA1624.severity = error
442+
dotnet_diagnostic.SA1625.severity = error
443+
dotnet_diagnostic.SA1626.severity = error
444+
dotnet_diagnostic.SA1627.severity = error
445+
dotnet_diagnostic.SA1629.severity = error
446+
dotnet_diagnostic.SA1633.severity = error
447+
dotnet_diagnostic.SA1634.severity = error
448+
dotnet_diagnostic.SA1635.severity = error
449+
dotnet_diagnostic.SA1636.severity = error
450+
dotnet_diagnostic.SA1637.severity = none
451+
dotnet_diagnostic.SA1638.severity = none
452+
dotnet_diagnostic.SA1640.severity = error
453+
dotnet_diagnostic.SA1641.severity = error
454+
dotnet_diagnostic.SA1642.severity = error
455+
dotnet_diagnostic.SA1643.severity = error
456+
dotnet_diagnostic.SA1649.severity = error
457+
dotnet_diagnostic.SA1651.severity = error
458+
459+
dotnet_diagnostic.SX1101.severity = error
460+
dotnet_diagnostic.SX1309.severity = error
461+
dotnet_diagnostic.SX1623.severity = none
462+
dotnet_diagnostic.RCS1102.severity=error
463+
dotnet_diagnostic.RCS1166.severity=error
464+
dotnet_diagnostic.RCS1078i.severity=error
465+
dotnet_diagnostic.RCS1248.severity=error
466+
dotnet_diagnostic.RCS1080.severity=error
467+
dotnet_diagnostic.RCS1077.severity=error
468+
dotnet_diagnostic.CA1825.severity=error
469+
dotnet_diagnostic.CA1812.severity=error
470+
dotnet_diagnostic.CA1805.severity=error
471+
dotnet_diagnostic.RCS1197.severity=error
472+
dotnet_diagnostic.RCS1198.severity=suggestion
473+
dotnet_diagnostic.RCS1231.severity=suggestion
474+
dotnet_diagnostic.RCS1235.severity=error
475+
dotnet_diagnostic.RCS1242.severity=error
476+
dotnet_diagnostic.CA2016.severity=warning
477+
dotnet_diagnostic.CA2014.severity=error
478+
dotnet_diagnostic.RCS1010.severity=error
479+
dotnet_diagnostic.RCS1006.severity=error
480+
dotnet_diagnostic.RCS1005.severity=error
481+
dotnet_diagnostic.RCS1020.severity=error
482+
dotnet_diagnostic.RCS1049.severity=warning
483+
dotnet_diagnostic.RCS1058.severity=warning
484+
dotnet_diagnostic.RCS1068.severity=warning
485+
dotnet_diagnostic.RCS1073.severity=warning
486+
dotnet_diagnostic.RCS1084.severity=error
487+
dotnet_diagnostic.RCS1085.severity=error
488+
dotnet_diagnostic.RCS1105.severity=error
489+
dotnet_diagnostic.RCS1112.severity=error
490+
dotnet_diagnostic.RCS1128.severity=error
491+
dotnet_diagnostic.RCS1143.severity=error
492+
dotnet_diagnostic.RCS1171.severity=error
493+
dotnet_diagnostic.RCS1173.severity=error
494+
dotnet_diagnostic.RCS1176.severity=error
495+
dotnet_diagnostic.RCS1177.severity=error
496+
dotnet_diagnostic.RCS1179.severity=error
497+
dotnet_diagnostic.RCS1180.severity=warning
498+
dotnet_diagnostic.RCS1190.severity=error
499+
dotnet_diagnostic.RCS1195.severity=error
500+
dotnet_diagnostic.RCS1214.severity=error
501+
160502
# C++ Files
161503
[*.{cpp,h,in}]
162504
curly_bracket_next_line = true
@@ -183,3 +525,5 @@ indent_size = 2
183525
end_of_line = lf
184526
[*.{cmd, bat}]
185527
end_of_line = crlf
528+
529+
vsspell_dictionary_languages = en-US

0 commit comments

Comments
 (0)