Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ObserveOn(IObservable<TSource>, Control) duplicates in ReactiveUI.WinForms and System.Reactive #3885

Closed
Metadorius opened this issue Aug 27, 2024 · 2 comments · Fixed by #3964
Closed

[Bug]: ObserveOn(IObservable<TSource>, Control) duplicates in ReactiveUI.WinForms and System.Reactive #3885

Metadorius opened this issue Aug 27, 2024 · 2 comments · Fixed by #3964
Assignees
@ChrisPulman
Labels
bug

Comments

@Metadorius
Copy link

Describe the bug 🐞

Error CS0121 : The call is ambiguous between the following methods or properties: 'System.Reactive.Linq.ControlObservable.ObserveOn<TSource>(System.IObservable<TSource>, System.Windows.Forms.Control)' and 'System.Reactive.Linq.ControlObservable.ObserveOn<TSource>(System.IObservable<TSource>, System.Windows.Forms.Control)'

The methods are under the same namespace, and I believe they are the same method just moved to a different NuGet, so one of them has to go.

Step to reproduce

  1. Install ReactiveUI.WinForms and System.Reactive
  2. Try to use ObserveOn(IObservable<TSource>, Control)

Reproduction repository

No response

Expected behavior

The method can be used normally

Screenshots 🖼️

image

IDE

No response

Operating system

No response

Version

No response

Device

No response

ReactiveUI Version

ReactiveUI 20.1.1, System.Reactive 6.0.1

Additional information ℹ️

Using .NET Framework 4.8.
@Metadorius Metadorius added the bug label Aug 27, 2024
@zhyy2008z
Copy link

+1

@ChrisPulman ChrisPulman self-assigned this Feb 3, 2025
@ChrisPulman ChrisPulman mentioned this issue Feb 3, 2025
Merged
2 tasks
@ChrisPulman ChrisPulman linked a pull request Feb 3, 2025 that will close this issue
Update WinForms to remove ControlObservable #3964
Merged
2 tasks
ChrisPulman added a commit that referenced this issue Feb 9, 2025
@ChrisPulman @glennawatson
Update WinForms to remove ControlObservable (#3964)
510d73c 
<!-- Please be sure to read the
[Contribute](https://github.com/reactiveui/reactiveui#contribute)
section of the README -->

**What kind of change does this PR introduce?**
<!-- Bug fix, feature, docs update, ... -->

Fix for #3885 

**What is the current behavior?**
<!-- You can also link to an open issue here. -->

#3885 

**What is the new behavior?**
<!-- If this is a feature change -->

This Removes ObserveOn and SubscribeOn extensions that are included with
System.Reactive 6.0.1

**What might this PR break?**

None expected 

**Please check if the PR fulfills these requirements**
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

**Other information**:

Co-authored-by: Glenn <[email protected]>
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChrisPulman ChrisPulman

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update WinForms to remove ControlObservable reactiveui/ReactiveUI
3 participants
@ChrisPulman @zhyy2008z @Metadorius