Skip to content

Commit ebf7dcc

Browse files
authored
Fix For Xunit Async Tests (#3812)
<!-- Please be sure to read the [Contribute](https://github.com/reactiveui/reactiveui#contribute) section of the README --> **What kind of change does this PR introduce?** <!-- Bug fix, feature, docs update, ... --> Fix for XUint tests **What is the current behavior?** <!-- You can also link to an open issue here. --> Xunit 2.6.6 + fails to pass tests due to parallelism **What is the new behavior?** <!-- If this is a feature change --> Using XUnit 2.8.0 with config file setting the parallelAlgorithm to aggressive **What might this PR break?** none **Please check if the PR fulfills these requirements** - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) **Other information**:
1 parent 1d11336 commit ebf7dcc

File tree

5 files changed

+18
-2
lines changed

5 files changed

+18
-2
lines changed

src/Directory.Packages.props

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<FodyVersion>6.8.0</FodyVersion>
88
<SplatVersion>15.0.1</SplatVersion>
99
<XamarinAndroidSupportVersion>28.0.0.3</XamarinAndroidSupportVersion>
10-
<XUnitVersion>2.6.6</XUnitVersion>
11-
<VerifyXUnitVersion>23.2.0</VerifyXUnitVersion>
10+
<XUnitVersion>2.8.0</XUnitVersion>
11+
<VerifyXUnitVersion>24.2.0</VerifyXUnitVersion>
1212
</PropertyGroup>
1313
<ItemGroup>
1414
<PackageVersion Include="coverlet.msbuild" Version="6.0.2" />

src/ReactiveUI.Testing.Tests/ReactiveUI.Testing.Tests.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,8 @@
1212
<ItemGroup>
1313
<None Include="API\**\*.txt" CopyToOutputDirectory="PreserveNewest" LinkBase="/" />
1414
</ItemGroup>
15+
16+
<ItemGroup>
17+
<Content Include="xunit.runner.json" CopyToOutputDirectory="PreserveNewest" />
18+
</ItemGroup>
1519
</Project>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
3+
"parallelAlgorithm": "aggressive"
4+
}

src/ReactiveUI.Tests/ReactiveUI.Tests.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@
5858
<None Remove="Platforms\wpf\Mocks\FakeViewWithContractLocator3.cs" />
5959
<None Remove="Platforms\wpf\WpfGeneralFixture.cs" />
6060
<None Remove="Platforms\wpf\WpfGeneralFixtureApp.cs" />
61+
<None Remove="xunit.runner.json" />
62+
</ItemGroup>
63+
<ItemGroup>
64+
<Content Include="xunit.runner.json" CopyToOutputDirectory="PreserveNewest" />
6165
</ItemGroup>
6266
<ItemGroup>
6367
<Compile Update="Platforms\Winforms\Mocks\TestForm.Designer.cs">
+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
3+
"parallelAlgorithm": "aggressive"
4+
}

0 commit comments

Comments
 (0)