Fix to enable use of DynamicData 9.0 (#3875)

ChrisPulman · web-flow · commit c8b03969f04f · 2024-08-11T22:34:05.000+01:00
**What kind of change does this PR introduce?**  fix **What is the current behavior?**  ReactiveUI 20.1.1 includes DynamicData 8 DynamicData 9 has an update to the Observable Change Set which introduces a default value, this results in a mismatch in count between V8 and V9 **What is the new behavior?**  the default value has been removed from the RoutingState CurrentViewModel **What might this PR break?** Execution should match previous versions **Please check if the PR fulfills these requirements** - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) **Other information**:
diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props
@@ -8,7 +8,7 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageVersion Include="coverlet.msbuild" Version="6.0.2" />
-    <PackageVersion Include="DynamicData" Version="8.4.1" />
+    <PackageVersion Include="DynamicData" Version="9.0.1" />
     <PackageVersion Include="FluentAssertions" Version="6.12.0" />
     <PackageVersion Include="JetBrains.DotMemoryUnit" Version="3.2.20220510" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" />
diff --git a/src/ReactiveUI/Routing/RoutingState.cs b/src/ReactiveUI/Routing/RoutingState.cs
@@ -125,6 +125,6 @@ private void SetupRx()
              return Navigate.Execute(vm);
          });
 
-        CurrentViewModel = Observable.Defer(() => Observable.Return(NavigationStack.LastOrDefault()!)).Concat(NavigationChanged.Select(_ => NavigationStack.LastOrDefault()!));
+        CurrentViewModel = NavigationChanged.Select(_ => NavigationStack.LastOrDefault()!);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,6 @@ private void SetupRx()`
`125`	`125`	`return Navigate.Execute(vm);`
`126`	`126`	`});`
`127`	`127`
`128`		`- CurrentViewModel = Observable.Defer(() => Observable.Return(NavigationStack.LastOrDefault()!)).Concat(NavigationChanged.Select(_ => NavigationStack.LastOrDefault()!));`
	`128`	`+ CurrentViewModel = NavigationChanged.Select(_ => NavigationStack.LastOrDefault()!);`
`129`	`129`	`}`
`130`	`130`	`}`