Skip to content

Commit a31490e

Browse files
ChrisPulmanChrisPulman
authored
Housekeeping Update Build to use dotnet build (#3799)
<!-- Please be sure to read the [Contribute](https://github.com/reactiveui/reactiveui#contribute) section of the README --> **What kind of change does this PR introduce?** <!-- Bug fix, feature, docs update, ... --> Update build script **What is the current behavior?** <!-- You can also link to an open issue here. --> using MsBuild **What is the new behavior?** <!-- If this is a feature change --> using DotNet Build **What might this PR break?** none expected **Please check if the PR fulfills these requirements** - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) **Other information**:
1 parent 8e33bf4 commit a31490e

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

‎.github/workflows/ci-build.yml

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ jobs:
2020
with:
2121
configuration: Release
2222
productNamespacePrefix: "ReactiveUI"
23+
dotNetBuild: true
2324
useVisualStudioPreview: false
2425
useMauiCheckDotNetTool: false
2526
solutionFile: "reactiveui.sln"

‎.github/workflows/release.yml

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
with:
1616
configuration: Release
1717
productNamespacePrefix: "ReactiveUI"
18+
dotNetBuild: true
1819
useVisualStudioPreview: true
1920
useMauiCheckDotNetTool: false
2021
solutionFile: "reactiveui.sln"

‎src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
<NoWarn>$(NoWarn);NETSDK1206</NoWarn>
1010
<DefineConstants>IS_WINUI;WINUI_TARGET;</DefineConstants>
1111
<RuntimeIdentifiers>win-x64;win-x86;win-arm64</RuntimeIdentifiers>
12+
<EnableMsixTooling>true</EnableMsixTooling>
1213
<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.19041.0</SupportedOSPlatformVersion>
1314
<TargetPlatformMinVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.19041.0</TargetPlatformMinVersion>
1415
</PropertyGroup>

‎src/global.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "8.0.204",
3+
"version": "8.0.10",
44
"rollForward": "latestMinor"
55
},
66
"msbuild-sdks": {

0 commit comments

Comments
 (0)