Skip to content

Shorten the description of !ask#31

Merged
vcarl merged 2 commits intomasterfrom
nickmccurdy-patch-1
Jan 30, 2020
Merged

Shorten the description of !ask#31
vcarl merged 2 commits intomasterfrom
nickmccurdy-patch-1

Conversation

@nickserv
Copy link
Copy Markdown
Contributor

The example is too generic to be useful and doesn't have an actionable question, meanwhile the code help isn't as detailed as !code and is just taking up extra space

Copy link
Copy Markdown
Member

@BTMPL BTMPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I'm not sure this will not sound a bit rough with just this one sentence.

@nickserv
Copy link
Copy Markdown
Contributor Author

Any suggestions to change the first sentence? Personally I don't think the removed text provides any more friendless/reassurance though.

@vcarl
Copy link
Copy Markdown
Member

vcarl commented Jan 29, 2020

I feel like it's a little short to merit a bot response—this wouldn't be hard to type out manually and skip the whole impersonal aspect. The sentence + some examples I think would strike a balance, and can strip some lines to make the overall thing shorter. Maybe:

Instead of asking to ask, ask your question instead.

Bad: "hey can anyone help me?"	
Bad: "anyone good with redux?"
Good: 
> I'm trying to fire a redux action from my component, but it's not getting to the reducer.
> \`\`\`js
> // snippet of code
> \`\`\`
> I'm seeing an error, but I don't know if it's related.
> \`Uncaught TypeError: undefined is not a function\`

This^ looks like it's 3 lines shorter than the current version and the example question is actually a decent representation

@nickserv
Copy link
Copy Markdown
Contributor Author

I added the example, but I still think this line is important as it explains why this is suggested:

People can help you better if they know your question.

@vcarl
Copy link
Copy Markdown
Member

vcarl commented Jan 30, 2020

Sounds good to me!

@vcarl vcarl merged commit 8031c79 into master Jan 30, 2020
@vcarl vcarl deleted the nickmccurdy-patch-1 branch January 30, 2020 19:51
vcarl pushed a commit that referenced this pull request Dec 28, 2020
* feat: support new extend command

* fix: review

* feat: add expiration date and mentioned users in private-chat topic
vcarl pushed a commit that referenced this pull request Dec 28, 2020
* feat: support new extend command

* fix: review

* feat: add expiration date and mentioned users in private-chat topic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants