Skip to content

Comments

chore: Test Docusaurus webpack 5 support#974

Merged
eriveltonelias merged 7 commits intoreact-navigation:mainfrom
slorber:slorber/webpack5
May 8, 2021
Merged

chore: Test Docusaurus webpack 5 support#974
eriveltonelias merged 7 commits intoreact-navigation:mainfrom
slorber:slorber/webpack5

Conversation

@slorber
Copy link
Member

@slorber slorber commented Apr 16, 2021

Use an unreleased version of Docusaurus to test the webpack5 support works for this site.

See also facebook/docusaurus#4089

@netlify
Copy link

netlify bot commented Apr 16, 2021

@slorber slorber changed the title Test Docusaurus webpack 5 support chore: Test Docusaurus webpack 5 support Apr 16, 2021
@slorber
Copy link
Member Author

slorber commented Apr 16, 2021

weird, netlify does not work 😓 (also on last commit of main)

@slorber
Copy link
Member Author

slorber commented Apr 23, 2021

@satya164 @eriveltonelias it looks like the deploy previews are broken on Netlify.

Can you click on "retry / clear cache" here please? I think it may solve the problem.

https://app.netlify.com/sites/react-navigation-docs/deploys

@slorber
Copy link
Member Author

slorber commented Apr 23, 2021

Thanks @satya164

Not sure why Netlify does not seem to use the build plugin but it seems we still see Webpack 5 persistent caching improvements:

image

@slorber slorber marked this pull request as ready for review April 30, 2021 17:43
@slorber
Copy link
Member Author

slorber commented Apr 30, 2021

ready for review!

"@docusaurus/plugin-google-analytics": "^2.0.0-alpha.66",
"@docusaurus/preset-classic": "^2.0.0-alpha.72",
"@docusaurus/core": "2.0.0-alpha.75",
"@docusaurus/plugin-google-analytics": "2.0.0-alpha.75",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slorber for your PR! just one small thing to check before we land it.

@brentvatne could you check if this new version GA plugin still working the analytics?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Do you expect me to do anything?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, all looks good to me @slorber, thanks again for your awesome work on docusarus.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriveltonelias - i can add you to the google analytics account, dm me on discord to let me know what email to add :)

@eriveltonelias eriveltonelias merged commit 354a1bc into react-navigation:main May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants