-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Closed
Description
Current Behavior
I have tried to upgrade from :
| software | version |
| ------------------------------ | ------- |
| iOS or Android | iOS, Android and web
| @react-navigation/native | 5.0.0-alpha.22
| @react-navigation/stack | 5.0.0-alpha.63
| @react-navigation/drawer | 5.0.0-alpha.41
| react-native-reanimated | 1.4.0
| react-native-gesture-handler | 1.5.3
| react-native-safe-area-context | 0.6.2
| react-native-screens | 2.0.0-alpha.32
| react-native | https://github.com/expo/react-native/archive/sdk-36.0.0.tar.gz
| expo | SDK36
| node | v13.5.0
| npm or yarn | 6.13
To
| software | version |
| ------------------------------ | ------- |
| iOS or Android | iOS, Android and web
| @react-navigation/native | 5.0.0
| @react-navigation/stack | 5.0.0
| @react-navigation/drawer | 5.0.0
| react-native-reanimated | 1.4.0
| react-native-gesture-handler | 1.5.3
| react-native-safe-area-context | 0.6.2
| react-native-screens | 2.0.0-beta.1
| react-native | https://github.com/expo/react-native/archive/sdk-36.0.0.tar.gz
| expo | SDK36
| node | v13.5.0
| npm or yarn | 6.13
I have checked the example and thanks. I have upgrade safely all my dependencies to latest except:
react-native-webis 0.11.7 due to react-native-web implementation of AsyncStorage react-native-async-storage/async-storage#52react-native-screensis2.0.0.beta.1due to Upgrade from 2.0.0-beta.1 to 2.0.0-beta.2 break web application software-mansion/react-native-screens#311react-native-safe-area-contextis0.6.2due to Upgrade from 0.6.4 to 0.7.0 break my app AppAndFlow/react-native-safe-area-context#49
I am now trying to upgrade the following:
@react-navigation/drawer ^5.0.0-alpha.41 → ^5.0.0
@react-navigation/native ^5.0.0-alpha.22 → ^5.0.0
@react-navigation/stack ^5.0.0-alpha.63 → ^5.0.0 I have followed all of your recommendations and to be precise:
- Open the source that used to create
NavigationNativeContainerand replaceNavigationNativeContainerforNavigationContainerin all the file. - Verify that the import line is equal to
import { NavigationContainer } from '@react-navigation/native'; - run
expo start -cto clear expo cache and notice that both app start on android and ios. - check at my test and they are all failing:
TypeError: Cannot read property 'split' of undefined
at Object.<anonymous> (node_modules/@react-navigation/stack/lib/commonjs/views/Stack/CardStack.tsx:42:26)
at Object.<anonymous> (node_modules/@react-navigation/stack/lib/commonjs/views/Stack/StackView.tsx:8:1)
- I have also tried to downgrade dependencies to be as in the demo (ex:
react-native-safe-area-contextto 0.6.2 instead of 0.6.4) and that didn't help, error is in there:
| const maybeExpoVersion = global.Expo?.Constants.manifest.sdkVersion.split( |
I've decided to stick to alpha version until I get some more info.
Just to confirm the version used:
├─┬ @react-navigation/[email protected]
│ └─┬ @react-navigation/[email protected]
│ └── @react-navigation/[email protected] deduped
└─┬ @react-navigation/[email protected]
└── @react-navigation/[email protected]
Expected Behavior
I expect the upgrade to go smoothly
mhuggins