Skip to content

[ANDROID] Allow using a custom RNCWebView in New Architecture#3586

Closed
marco-saia-datadog wants to merge 1 commit intoreact-native-webview:masterfrom
marco-saia-datadog:master
Closed

[ANDROID] Allow using a custom RNCWebView in New Architecture#3586
marco-saia-datadog wants to merge 1 commit intoreact-native-webview:masterfrom
marco-saia-datadog:master

Conversation

@marco-saia-datadog
Copy link
Copy Markdown

@marco-saia-datadog marco-saia-datadog commented Oct 15, 2024

What does this PR do?

Adds a createViewInstance override to RNCWebViewManager in new architecture, to allow using a custom RNCWebView, in accordance with the official guide for Android Customization.

Usage

With this change, the official guide will still be relevant:

@ReactModule(name = CustomWebViewManager.REACT_CLASS)
public class CustomWebViewManager extends RNCWebViewManager {
  /* This name must match what we're referring to in JS */
  protected static final String REACT_CLASS = "RCTCustomWebView";

  protected static class CustomWebViewClient extends RNCWebViewClient { }

  protected static class CustomWebView extends RNCWebView {
    public CustomWebView(ThemedReactContext reactContext) {
      super(reactContext);
    }
  }

  // This is currently not possible in New Architecture
  @Override
  protected RNCWebView createViewInstance(ThemedReactContext reactContext) {
    return super.createViewInstance(reactContext, new CustomWebView(reactContext));
  }

  @Override
  public String getName() {
    return REACT_CLASS;
  }

  @Override
  protected void addEventEmitters(ThemedReactContext reactContext, RNCWebViewWrapper view) {
    view.getWebView().setWebViewClient(new CustomWebViewClient());
  }
}

@marco-saia-datadog marco-saia-datadog mentioned this pull request Oct 15, 2024
Merged
5 tasks
@marco-saia-datadog
Copy link
Copy Markdown
Author

marco-saia-datadog commented Nov 19, 2024

⬆️ Friendly bump :)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 19, 2025

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jan 19, 2025
@believer
Copy link
Copy Markdown

believer commented Jan 22, 2025

This PR is still relevant. We've patched it in and custom views are working for us with it. When you have time, please have a look @Titozzz or @jamonholmgren.

@github-actions github-actions bot removed the Stale label Jan 23, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2025

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Mar 24, 2025
@marco-saia-datadog
Copy link
Copy Markdown
Author

marco-saia-datadog commented Mar 24, 2025

👋 @Titozzz @jamonholmgren

Could you take a look into this, please?

@github-actions github-actions bot removed the Stale label Mar 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 18, 2025

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jun 18, 2025
@github-actions github-actions bot closed this Jun 25, 2025
@believer
Copy link
Copy Markdown

believer commented Jun 25, 2025

This is still an issue in our project. Any chance of reopening this PR?

@marco-saia-datadog marco-saia-datadog mentioned this pull request Sep 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Titozzz Titozzz Awaiting requested review from Titozzz Titozzz is a code owner

@jamonholmgren jamonholmgren Awaiting requested review from jamonholmgren jamonholmgren is a code owner

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marco-saia-datadog @believer