rename start/end properties internally (React Native .51 compatibility)#244
Closed
koenpunt wants to merge 1 commit into
Closed
rename start/end properties internally (React Native .51 compatibility)#244koenpunt wants to merge 1 commit into
koenpunt wants to merge 1 commit into
Conversation
to prevent clash with RN Yoga properties
koenpunt
changed the title
|
Should probably update the typings for "startPoint" and "endPoint" |
Contributor
Author
|
Don’t think so, because the public api didn’t change. |
|
Ah I see, the other PR does have breaking changes to the public API. My mistake, that's the one I had forked. |
Contributor
|
I have updated my original PR to support android. |
Contributor
Author
|
Great, will close this then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to prevent clash with RN Yoga properties
Same like some other PRs (#243, #242), but with the exception that I didn't change the public API, and so the upgrade is non-breaking.