Add Windows info to react-native info#1227
Merged
alloy merged 6 commits intoreact-native-community:masterfrom Aug 11, 2020
Merged
Add Windows info to react-native info#1227alloy merged 6 commits intoreact-native-community:masterfrom
alloy merged 6 commits intoreact-native-community:masterfrom
Conversation
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1227 in repo react-native-community/cli |
Contributor
Author
thymikee
approved these changes
Jul 22, 2020
Contributor
Author
|
FYI I need another change that will be in 7.7.2 so marked this as draft until it's ready, thanks for reviewing :) |
Contributor
Author
Contributor
Author
|
I don't have a mac to test this on (only Windows) so I'd love to get someone to try this on a mac before we merge it. const info = await _envinfo().default.run({
System: ['OS', 'CPU', 'Memory', 'Shell'],
Binaries: ['Node', 'Yarn', 'npm', 'Watchman'],
IDEs: ['Xcode', 'Android Studio'],
Managers: ['CocoaPods'],
Languages: ['Java', 'Python'],
SDKs: ['iOS SDK', 'Android SDK'],
npmPackages: ['react', 'react-native', '@react-native-community/cli'],
npmGlobalPackages: ['*react-native*']
}, options);So I think this means we will not hit the mac crash but I'd love someone to help me verify this on a mac |
Member
|
(I’m OOO, so unsure when I’ll be able to test this. If somebody else has a minute before me, testing this would be much appreciated 🙏 /cc @acoates-ms ) |
Contributor
|
I ran through the info command on a mac. Seems to run just fine. |
Member
|
Great, thanks! |
thymikee
added a commit
that referenced
this pull request
Sep 17, 2020
* origin/master: (81 commits) chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (#1267) v4.13.0 chore: remove await in getLatestFile function call from downloadProfile file. (#1266) Augment react-native info with out of tree platform packages info (#1264) feat: add a command to download the Hermes Sampling Profiler to a local machine (#1246) chore(deps): bump lodash from 4.17.15 to 4.17.19 (#1221) Fix package name for main activity when appId set (#1242) Just use the users default browser (#1257) feat: improve progress indicator for iOS builds without xcpretty (#1254) fix: 🐛 executableFolderPath to run app name in iOS 14.0 (#1236) chore(deps): bump elliptic from 6.5.2 to 6.5.3 (#1233) v4.12.0 Add Windows info to react-native info (#1227) add new version RN Podfile link, autolinking docs. (#1245) docs: add linkage instructions for `yarn` v2 (#1237) v4.11.0 fix: adjust range on react-native peer dep to support 0.63 (#1234) chore: update jest config (#1241) Use new chrome based edge if the user is already running it, and not running chrome (#1222) Add windows logic to guess the users preferred editor for launchEditor (#1216) ...
thymikee
added a commit
to imoans/cli
that referenced
this pull request
Sep 17, 2020
* origin/master: (47 commits) chore(breaking): use Node 10 as compile target (react-native-community#1072) chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (react-native-community#1267) v4.13.0 chore: remove await in getLatestFile function call from downloadProfile file. (react-native-community#1266) Augment react-native info with out of tree platform packages info (react-native-community#1264) feat: add a command to download the Hermes Sampling Profiler to a local machine (react-native-community#1246) chore(deps): bump lodash from 4.17.15 to 4.17.19 (react-native-community#1221) Fix package name for main activity when appId set (react-native-community#1242) Just use the users default browser (react-native-community#1257) feat: improve progress indicator for iOS builds without xcpretty (react-native-community#1254) fix: 🐛 executableFolderPath to run app name in iOS 14.0 (react-native-community#1236) chore(deps): bump elliptic from 6.5.2 to 6.5.3 (react-native-community#1233) v4.12.0 Add Windows info to react-native info (react-native-community#1227) add new version RN Podfile link, autolinking docs. (react-native-community#1245) docs: add linkage instructions for `yarn` v2 (react-native-community#1237) v4.11.0 fix: adjust range on react-native peer dep to support 0.63 (react-native-community#1234) chore: update jest config (react-native-community#1241) Use new chrome based edge if the user is already running it, and not running chrome (react-native-community#1222) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds information about Windows-specific SDK and IDE necessary for react-native-windows, to
react-native info.It builds on a recent change I made to
envinfoto expose this information.Test Plan:
Manually ran:
node .\packages\cli\build\bin.js infoon Windows. Relying on CI to validate other platforms.