Add support for stroke-based icons#284
Open
tromgy wants to merge 1 commit into
Open
Conversation
- Add support for SVGs with: inline styles, internal CSS, stroke presentation attributes, and <text> - Add Predix Design System icons - Change the build process to copy the artifacts into the preview for easy verification - Disable linting of generated code (it takes hours to lint it, and it's of little value) - Add react plugin for eslint, so the demo code can be linted properly as JSX - Fix few of the remaining linting errors - Document how to add icons in README.md
Member
|
Thank you for your contribution! Currently, I am recursively checking using HasStrokes at runtime, but I think that it can be solved at build time. Also, please submit the PR of project settings(eslint etc) and new functions in separate PRs. |
Author
|
I agree that it makes sense to split it into two separate requests. I tried to split this one, but that turned out to be tricky if at all possible, and I had to revert it so it is as it was back in January. I'm going to try creating two separate requests from two different branches of my forked repo. |
This was referenced Dec 5, 2020
kamijin-fanta
force-pushed
the
master
branch
2 times, most recently
from
039502a to
399b45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address issue #282. Icons having
strokeattribute will now render properly. Fill-based (stroke-less) icons will render as before.Here's what this pull request tries to accomplish:
<text>