Repository navigation
fix: omit disabled options from multi-select changes - #14002
Merged
Merged
Conversation
Ignore disabled options and disabled optgroup descendants when reading a multiple select. Preserve custom refs without DOM methods.
Cover selectedOptions objects that provide values without element methods.
Exercise DOM changes, submission, disabled optgroups, and explicit defaultValues and setValue assignments.
bluebill1049
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Disabled options remain in
selectedOptions, so changing a multiple select currently includes disabled options and options inside disabled optgroups in the form value and submission. It also letsrequiredpass when only disabled options remain selected.Filter disabled options when reading the DOM selection, consistently with checkbox and radio groups. The optgroup check follows the full ancestor chain, while the optional method call preserves custom select refs without DOM methods. Explicit
defaultValuesandsetValueassignments remain intact.Regression coverage includes selection and submission, required validation, explicit value assignments, and custom select refs.
Type of change
Test plan
pnpm test --runInBand: 133 suites, 1,836 tests and 26 snapshots passed.pnpm build,pnpm type,pnpm test:type, andpnpm lintpassed.createFormControlchecks cover custom refs, dynamic disabled groups and explicit value assignments.Checklist: