Repository navigation
fix(form): honor encType when selecting request body - #13997
Merged
Merged
Conversation
Use the non-multipart encType for body encoding and replace Content-Type headers case-insensitively. Preserve existing multipart boundary handling.
Cover conflicting encodings, mixed-case Content-Type headers, and multipart controls. Check the normalized request headers and body while preserving other headers and the caller-provided object.
bluebill1049
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When
Formreceives bothencTypeand aContent-Typeheader, it can send a body using a different encoding from the final header. For example,encType="application/x-www-form-urlencoded"with a JSON header sends a JSON body under a URL-encoded content type. A differently cased header can also be duplicated when Fetch normalizes the names.Use the existing non-multipart
encTypeprecedence for both body selection and the final header, replacing overridden header names case-insensitively. Preserve multipart boundary handling, other headers, and the caller-provided headers object.Add 18 regression and compatibility cases for JSON, URL-encoded and text bodies, mixed-case headers, and multipart combinations. Ten new cases fail against the original implementation.
Validation with Node 22:
pnpm type,pnpm test:type, lint, Prettier, builds, and both API Extractor checks passed. No added lint warnings; the API report is unchanged.Type of change
Checklist: