Repository navigation
fix(useController): preserve values when shouldUnregister changes - #13996
Merged
Merged
Conversation
Keep the field-level unregistration option in a committed ref so changing it does not tear down an input that is still mounted. Preserve the previous field policy when the name or control changes.
Update default-value initialization with the option without unregistering a mounted input. Keep cleanup tied to the previous field identity.
Cover mounted option changes, name and control transitions, and inline default values after reset. Preserve form-level overrides and unmount behavior.
Contributor
Author
|
The failing The other five CI checks passed. Could a maintainer rerun the failed E2E job? |
bluebill1049
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changing the field-level
shouldUnregisteroption reruns the registration effect and cleans up an input that is still mounted. For example, changingtruetofalseremoves its edited value fromgetValues().Track the committed option independently of registration. Update default-value initialization when the option changes, while keeping registration and cleanup tied to field identity. This preserves inline defaults after
reset()and the previous field policy whennameorcontrolchanges. Form-level precedence and the field-array action guard stay unchanged. This complements #13956 for the field-level option.Add 12 cases covering option transitions, form-level overrides, identity changes, and inline defaults. Four mounted-option cases fail against the original implementation.
Validation with Node 22:
pnpm type,pnpm test:type, lint, Prettier, builds, and both API Extractor checks passed. No added lint warnings; the API report is unchanged.Type of change
Checklist: