Repository navigation
fix(types): preserve undefined in nested array element values - #13995
Merged
Merged
Conversation
Refactor type handling for array keys in PathValueImpl.
Cover ordinary and readonly arrays with explicit undefined elements, nested paths and leaf unions. Keep tuple and variadic rest inference unchanged.
Assert the public getValues return type for an array whose elements may be undefined.
bluebill1049
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For
rows: ({ name: string } | undefined)[],getValues("rows.0.name")is inferred asstring, although the selected row can beundefined. The recursive array branch drops the explicitundefinedelement type.Preserve it for ordinary and readonly arrays. Keep fixed and variadic tuple inference unchanged. Add type regressions for nested paths, leaf unions, tuple controls, and the public
getValuesresult. The four affected assertions fail against the original implementation.Validation with Node 22:
pnpm type,pnpm test:type, lint, Prettier, builds, and both API Extractor checks passed. No added lint warnings; the API report is unchanged.Type of change
Checklist: