Repository navigation
🐞 fix(useFieldArray): ignore duplicated indexes and keep the indexes passed to remove unchanged - #13830
Merged
bluebill1049 merged 1 commit intoOct 5, 2026
Conversation
…passed to remove unchanged Signed-off-by: Charan Rathore <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Proposed Changes
removefromuseFieldArrayhas two problems with the indexes you pass in:a, b, c, d,remove([1, 1])removes bothbandc, because the second1is applied after the array has already shifted. With[a, c],remove([0, 0])removes everything.remove([3, 1])leaves your own array as[1, 3].The fix removes duplicates and sorts a copy before the rows are removed. Output for normal calls is the same.
I added tests for the util and for
useFieldArray.remove. They fail without the fix.Fixes # (no issue, found while testing field array helpers)
Type of change
Checklist: