Repository navigation
fix: refresh criteriaMode flag when form options are updated at runtime - #13737
Merged
bluebill1049 merged 1 commit intoSep 11, 2026
Merged
bluebill1049 merged 1 commit into
bluebill1049 merged 1 commit into
Conversation
bluebill1049
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the criteriaMode prop after mount had no effect on validation output.
The shouldDisplayAllAssociatedErrors flag was captured once when the form control was created, while mode and reValidateMode are already refreshed whenever options are assigned. This change refreshes the criteriaMode-derived flag in the same setter, so switching between firstError and all at runtime takes effect on the next validation.
Verified with runtime-switch tests in both directions (firstError to all and back), plus the full test suite, tsc, and eslint.