Repository navigation
fix: cancel nested delayError timers when a parent is cleared or unregistered - #13736
Merged
bluebill1049 merged 2 commits intoSep 11, 2026
Conversation
bluebill1049
approved these changes
Sep 11, 2026
6 tasks done
bluebill1049
added a commit
that referenced
this pull request
Sep 20, 2026
…13771) `executeSchemaAndUpdateState` unsets the whole subtree of each validated name, but only cancelled that exact name's delayError timer. A timer already scheduled for a nested field therefore survived the validation and, when it fired, wrote its stale error back into form state — under a subtree the resolver had just reported clean. Use `cancelDelayedErrorTree`, as `clearErrors`, `unregister` and `resetField` already do for the same reason (#13736, #13769). Co-authored-by: Bill <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Clearing or unregistering a parent field removes the whole nested error subtree from
errors, but a pendingdelayErrortimer for a nested child (keyed by its full path, e.g.parent.child) survived and put the error back once the delay elapsed. This adds acancelDelayedErrorTreehelper that cancels the exact name plus any nestedname.-prefixed timers, and uses it inclearErrorsandunregister. The dot boundary keeps sibling fields liketest1untouched whentestis cleared.Self-review
clearErrors.test.tsx(nested cascade + prefix-boundary guard) andunregister.test.tsx(nested cascade); verified they fail without the fix.tscandeslintclean.