feat(types): support flat field arrays#13249
Merged
bluebill1049 merged 1 commit intoreact-complierfrom Jan 13, 2026
Merged
Conversation
Update ArrayPath type to allow arrays of primitive values (string[], number[], etc.) in addition to object arrays. Previously, useFieldArray field types were limited to objects. Now primitive types are supported by removing the BrowserNativeObject check from ArrayPathImpl, enabling use cases like: - tags: string[] - scores: number[] - matrix: string[][] This is a type-only change with no runtime modifications.
Contributor
|
Size Change: 0 B Total Size: 58.5 kB ℹ️ View Unchanged
|
bluebill1049
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds TypeScript type support for flat field arrays (arrays containing primitive values) in useFieldArray. Previously, useFieldArray only supported arrays of objects, but this change allows primitive arrays such as string[], number[], and multi-dimensional primitive arrays like string[][].
This is a type-only change with no runtime modifications.
Changes
Type Definition Update:
Before:
After:
Review Point: IDE Type Representation for Primitive Field Arrays
This change allows
useFieldArrayto support primitive arrays by modeling each field as an intersection type:This is necessary to attach the internal
keyproperty, but it has a noticeable impact on how types are displayed in IDEs.Observed Issue
When hovering over
fieldsin editors like VSCode, the type is expanded very verbosely due to the structural nature ofstring:This makes the type significantly harder to read and may be confusing for users, especially compared to object-based field arrays.
Current State
Open Question for Reviewers
I’m not fully confident that this IDE experience is acceptable as-is.
I’d like feedback on: