fix: update isValid when field disabled state changes#13231
Merged
bluebill1049 merged 2 commits intoreact-hook-form:masterfrom Jan 4, 2026
Merged
Conversation
- Auto-trigger validation in _setDisabledField when disabled state changes - Add test for disabled state toggling with isValid in onChange mode Fixes issue where isValid doesn't recalculate when a field's disabled state changes, causing forms to show stale validation state. Signed-off-by: a28689604 <[email protected]>
a28689604
force-pushed
the
fix/update-isvalid-on-disabled-state-change
branch
from
6589ca2 to
d33e021
Compare
Signed-off-by: a28689604 <[email protected]>
bluebill1049
approved these changes
Jan 4, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Problem
When toggling a field's
disabledstate inmode: 'onChange',isValiddoes not automatically recalculate. While disabled fields correctly skip validation, the form state becomes stale when the disabled state changes, causingisValidto not reflect the current validation state.Example:
isValid = falseisValidstaysfalseisValid = true(no enabled fields are invalid)Solution
Modified
_setDisabledFieldto detect when disabled state actually changes and trigger validation automatically.Fixes #13176
Type of change
Please delete options that are not relevant.
Checklist: