fix: improve invalid date handling in deepEqual and validation#13230
Merged
bluebill1049 merged 2 commits intoreact-hook-form:masterfrom Jan 1, 2026
Merged
Conversation
- Use Object.is() for Date timestamp comparison to handle NaN correctly - Detect invalid date-like objects (Dayjs, Moment) via getTime() method - Add comprehensive test coverage for invalid Date comparisons Signed-off-by: a28689604 <[email protected]>
bluebill1049
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes validation not triggering in onChange mode when using invalid date values from date libraries like Dayjs.
Invalid Date objects now correctly compare as equal since their NaN timestamps are properly handled by Object.is().
Fixes #13224
Type of change
Checklist: