perf: reduce redundant property access in getDirtyFields#13146
Merged
bluebill1049 merged 1 commit intoreact-hook-form:masterfrom Nov 14, 2025
Merged
Conversation
Cache data[key] and formValues[key] in variables to eliminate repeated lookups. Performance improvement: ~10% faster across different form sizes. - Medium forms (50 fields): 19.58ms → 17.44ms (11.0% faster) - Large forms (100+ fields): 21.48ms → 19.65ms (8.5% faster) All tests pass (13/13).
kimtaejin3
changed the title
Member
|
wow |
bluebill1049
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
getDirtyFields.ts,data[key]andformValues[key]are accessed multiple times per iteration, causing unnecessary property lookup overhead.Solution
Cache property values in variables to eliminate redundant lookups.
Changes
const value = data[key]inmarkFieldsDirtyfunctionconst value = data[key]ingetDirtyFieldsmain loopconst formValue = formValues[key]in else blockPerformance Results
Benchmarked 5 times with consistent results:
Average improvement: ~10%
Testing