fix(useForm): recompute isValid after reset when values update asynchronously by a28689604 · Pull Request #13126 · react-hook-form/react-hook-form

a28689604 · 2025-11-04T14:18:25Z

Proposed Changes

Problem:

When props.values are set asynchronously, formState.isValid wasn’t recalculated because reset() sets control._state.mount = true, so the useForm mount effect that calls _setValid() no longer runs.

Root cause flow:

values are set asynchronously.
useForm effect runs due to props.values change:

react-hook-form/src/useForm.ts

Lines 154 to 165 in 4922698

    
           React.useEffect(() => { 
        
             if (props.values && !deepEqual(props.values, _values.current)) { 
        
               control._reset(props.values, { 
        
                 keepFieldsRef: true, 
        
                 ...control._options.resetOptions, 
        
               }); 
        
               _values.current = props.values; 
        
               updateFormState((state) => ({ ...state })); 
        
             } else { 
        
               control._resetDefaultValues(); 
        
             } 
        
           }, [control, props.values]);

_reset() is called.

After reset, control._state.mount becomes true following the changes in fix: watch() returning undefined immediately after reset() - Issue #13088 #13091, so the mount effect below doesn’t call _setValid() anymore:

react-hook-form/src/useForm.ts

Lines 167 to 171 in 4922698

    
           React.useEffect(() => { 
        
             if (!control._state.mount) { 
        
               control._setValid(); 
        
               control._state.mount = true; 
        
             }

Fix:

Recompute validity at the end of _reset() while respecting keep-state options.

Fixes #13123

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing tests pass locally with my changes

…ronously - Call _setValid() at the end of _reset() unless keepIsValid is set. - Ensures formState.isValid updates correctly when props.values change asynchronously. Signed-off-by: Eric Chen <[email protected]>

bluebill1049 · 2025-11-04T22:40:19Z

src/logic/createFormControl.ts

      defaultValues: _defaultValues as FormState<TFieldValues>['defaultValues'],
    });
+
+    !keepStateOptions.keepIsValid && _setValid();


Can this logic move to the hook level?

Sure, I’ve moved the code to useForm, and it now runs after the reset is completed.

- Call _setValid() in useForm when resetOptions.keepIsValid is false.

a28689604 · 2025-11-05T15:32:34Z

@bluebill1049
I found another issue, keepIsDirty doesn’t work as expected after version 7.60.0-next.0. It behaves correctly in 7.59.0.

Please check this example: when clicking the button, the form resets with invalid data, but isValid should remain true; instead, it changes.
https://codesandbox.io/p/sandbox/tender-ace-4434lg

Could you confirm if this is unintended behavior? If so, I’ll work on a fix and add a test file to cover this case.

bluebill1049 · 2025-11-09T00:48:54Z

yea keep dirty shouldn't affect isValid flag

fix(useForm): recompute isValid after reset when values update asynch…

e42a5ad

…ronously - Call _setValid() at the end of _reset() unless keepIsValid is set. - Ensures formState.isValid updates correctly when props.values change asynchronously. Signed-off-by: Eric Chen <[email protected]>

bluebill1049 reviewed Nov 4, 2025

View reviewed changes

fix(useForm): ensure validity state is updated after reset

020596d

- Call _setValid() in useForm when resetOptions.keepIsValid is false.

a28689604 requested a review from bluebill1049 November 5, 2025 15:31

bluebill1049 approved these changes Nov 9, 2025

View reviewed changes

bluebill1049 merged commit fb6423f into react-hook-form:master Nov 9, 2025
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(useForm): recompute isValid after reset when values update asynchronously#13126

fix(useForm): recompute isValid after reset when values update asynchronously#13126
bluebill1049 merged 2 commits intoreact-hook-form:masterfrom
a28689604:fix/isvalid-after-async-values-reset

a28689604 commented Nov 4, 2025 •

edited

Loading

Uh oh!

bluebill1049 Nov 4, 2025

Uh oh!

a28689604 Nov 5, 2025

Uh oh!

a28689604 commented Nov 5, 2025

Uh oh!

bluebill1049 commented Nov 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	React.useEffect(() => {
	if (props.values && !deepEqual(props.values, _values.current)) {
	control._reset(props.values, {
	keepFieldsRef: true,
	...control._options.resetOptions,
	});
	_values.current = props.values;
	updateFormState((state) => ({ ...state }));
	} else {
	control._resetDefaultValues();
	}
	}, [control, props.values]);

	React.useEffect(() => {
	if (!control._state.mount) {
	control._setValid();
	control._state.mount = true;
	}

Uh oh!

Comments

Conversation

a28689604 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Problem:

Root cause flow:

Fix:

Type of change

Checklist:

Uh oh!

bluebill1049 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

a28689604 Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

a28689604 commented Nov 5, 2025

Uh oh!

bluebill1049 commented Nov 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

a28689604 commented Nov 4, 2025 •

edited

Loading