Skip to content

Add isBounded property so items could be constrained within grid#549

Closed
artembykov wants to merge 1 commit into
react-grid-layout:masterfrom
artembykov:bounded-grid
Closed

Add isBounded property so items could be constrained within grid#549
artembykov wants to merge 1 commit into
react-grid-layout:masterfrom
artembykov:bounded-grid

Conversation

@artembykov

@artembykov artembykov commented Apr 26, 2017 •
edited
Loading

Copy link
Copy Markdown

This PR fixes #546

artembykov
artembykov commented Apr 26, 2017
View reviewed changes
Comment thread lib/GridItem.jsx Outdated
let top = this.state.dragging.top + deltaY;
let left = this.state.dragging.left + deltaX;

if (this.props.isBounded) {

@artembykov artembykov Apr 26, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constraints applied here

@artembykov artembykov changed the title Add isBounded property so items could be constrained within grid [WIP] Add isBounded property so items could be constrained within grid Apr 27, 2017
@artembykov artembykov changed the title [WIP] Add isBounded property so items could be constrained within grid Add isBounded property so items could be constrained within grid Apr 27, 2017
@rileylnapier rileylnapier mentioned this pull request Jul 6, 2017
Closed
@artembykov

artembykov commented Sep 1, 2017

Copy link
Copy Markdown
Author

@STRML, what do you think about that PR? To clarify things a little bit more, these changes add a property which controls wether placeholders should be bounded within grid while dragging items around

@mpsk

mpsk commented Sep 8, 2017

Copy link
Copy Markdown

@artembykov, there are few file conflicts.
@STRML please, pay attention to this PR and merge as a fix is really important.

@artembykov
artembykov force-pushed the bounded-grid branch 3 times, most recently from d11ceb6 to 0124671 Compare February 14, 2018 12:41
@aslafy-z

aslafy-z commented Feb 14, 2018 •
edited
Loading

Copy link
Copy Markdown

Any ETA on getting this merged ? Thanks

@artembykov

artembykov commented Feb 14, 2018

Copy link
Copy Markdown
Author

ping @STRML
I've rebased on master today with one small perf improvement.

@0x6c23 0x6c23 mentioned this pull request Feb 24, 2018
Closed
2 tasks
@abenhamdine

abenhamdine commented Mar 23, 2018

Copy link
Copy Markdown

@artembykov there are file conflicts again.

@artembykov

artembykov commented Mar 31, 2018

Copy link
Copy Markdown
Author

@artembykov there are file conflicts again.

Resolved!

@abenhamdine

abenhamdine commented Apr 4, 2018

Copy link
Copy Markdown

@STRML any chance you can look at this ?

@aslafy-z

aslafy-z commented Jul 17, 2018

Copy link
Copy Markdown

@STRML would be great if you could merge this !

@ranbena ranbena mentioned this pull request Apr 19, 2019
Merged
10 tasks
@ranbena

ranbena commented Apr 19, 2019

Copy link
Copy Markdown

+1 for this

1 similar comment
@fedevegili

fedevegili commented May 16, 2019

Copy link
Copy Markdown

+1 for this

@ErkanSensei

ErkanSensei commented Oct 12, 2019

Copy link
Copy Markdown

Let's get this in please! This is an important feature

@github-actions

github-actions Bot commented Nov 11, 2019

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days

@github-actions github-actions Bot added the stale The label to apply when a pull request or an issue is stale label Nov 11, 2019
@aslafy-z

aslafy-z commented Nov 11, 2019

Copy link
Copy Markdown

This is still needed! #nostale

@github-actions github-actions Bot added documentation use this label for changes in documentation infrastructure labels Jan 6, 2020
@harleylang

harleylang commented Jul 19, 2020

Copy link
Copy Markdown

+1 still needed! Any chance this can be included in a future milestone?

STRML added a commit that referenced this pull request Jul 20, 2020
@STRML
feat(grid): Add 'isBounded' property from PR #549
bb1ac4c
@STRML STRML mentioned this pull request Jul 20, 2020
Merged
@STRML

STRML commented Jul 20, 2020

Copy link
Copy Markdown
Collaborator

Continued in #1248.

@STRML STRML closed this Jul 20, 2020
@STRML

STRML commented Jul 20, 2020

Copy link
Copy Markdown
Collaborator

Published in 1.0.0!

@harleylang

harleylang commented Jul 20, 2020

Copy link
Copy Markdown

Thank you thank you thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation use this label for changes in documentation infrastructure stale The label to apply when a pull request or an issue is stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How do I constrain elements to their container?

9 participants

@artembykov @mpsk @aslafy-z @abenhamdine @ranbena @fedevegili @ErkanSensei @harleylang @STRML