Skip to content

Commit 1b00e46

Browse files
committed
fix: preserve primitive parents when removing missing values
1 parent 4bef120 commit 1b00e46

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

‎src/utils/set.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,11 @@ function internalSet<Entity = any, Output = Entity, Value = any>(
2626
// Delete prop if `removeIfUndefined` and value is undefined
2727
if (removeIfUndefined && value === undefined && restPath.length === 1) {
2828
const origin = clone[path];
29-
const child = Array.isArray(origin) ? [...origin] : { ...origin };
30-
delete child[restPath[0]];
31-
clone[path] = child;
29+
if (origin && typeof origin === 'object') {
30+
const child = Array.isArray(origin) ? [...origin] : { ...origin };
31+
delete child[restPath[0]];
32+
clone[path] = child;
33+
}
3234
} else {
3335
clone[path] = internalSet(clone[path], restPath, value, removeIfUndefined);
3436
}

‎tests/utils.test.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,16 @@ describe('utils', () => {
9797
expect('lv4' in longTgt.lv1.lv2.lv3).toBeFalsy();
9898
});
9999

100+
it.each(['str', 123, true, Symbol('value'), BigInt(1)])(
101+
'preserves a primitive parent when removing a missing property: %s',
102+
value => {
103+
const source = { keep: value };
104+
const target = set(source, ['keep', 'light'], undefined, true);
105+
expect(target.keep).toBe(value);
106+
expect(source.keep).toBe(value);
107+
},
108+
);
109+
100110
describe('merge', () => {
101111
it('basic', () => {
102112
const merged = merge({}, { a: 1 }, { b: 2 });

0 commit comments

Comments
 (0)