Skip to content

Commit e0569f2

Browse files
committed
fix: support Space activation for upload controls
1 parent 71e6d72 commit e0569f2

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

‎src/AjaxUploader.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ class AjaxUploader extends Component<UploadProps> {
8686
};
8787

8888
onKeyDown = (e: React.KeyboardEvent<HTMLDivElement>) => {
89-
if (e.key === 'Enter') {
89+
if (e.key === 'Enter' || e.key === ' ') {
90+
e.preventDefault();
9091
this.onClick(e);
9192
}
9293
};

‎tests/uploader.spec.tsx‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1313,6 +1313,21 @@ describe('uploader', () => {
13131313
expect(container.querySelector('span')).toHaveAttribute('role', 'button');
13141314
});
13151315

1316+
it.each(['Enter', ' '])('Should open the file dialog with the %p key', key => {
1317+
const { container } = render(<Upload />);
1318+
const input = container.querySelector('input')!;
1319+
const clickSpy = jest.spyOn(input, 'click').mockImplementation(() => {});
1320+
const preventDefaultSpy = jest.spyOn(Event.prototype, 'preventDefault');
1321+
1322+
fireEvent.keyDown(container.querySelector('span')!, { key });
1323+
1324+
expect(clickSpy).toHaveBeenCalledTimes(1);
1325+
expect(preventDefaultSpy).toHaveBeenCalledTimes(1);
1326+
1327+
clickSpy.mockRestore();
1328+
preventDefaultSpy.mockRestore();
1329+
});
1330+
13161331
it("Should not be focusable and doesn't have role=button with hasControlInside=true", () => {
13171332
const { container } = render(<Upload hasControlInside />);
13181333

0 commit comments

Comments
 (0)