Document how to publish custom React Native version#675
Merged
Conversation
|
Oops, something went wrong with this deploy preview. @charpeni can you look at this? |
bartolkaruza
changed the title
gengjiawen
reviewed
Dec 2, 2018
| This binary needs to become available in your project's `node_modules/react-native/android` folder or directly in your gradle dependency of your Android app. You can achieve this in one of two ways: Git dependency branch, Android binary dependency through Maven. | ||
|
|
||
| To build the .aar React Native library, you can follow the steps to [build from source](building-from-source.md) first to install all required tooling. Then to build the actual library, you can run the following in the root of your react-native checkout: | ||
| ```$bash |
Contributor
There was a problem hiding this comment.
Can you consider make docker part TL, DR. And add links to docker website.
Contributor
There was a problem hiding this comment.
I want to show developers that make a fork is really simple.
gengjiawen
reviewed
Dec 4, 2018
| Alternatively, if you don't want to | ||
| install the required toolchain for building from source, you can use a prebuilt docker image to create a react native binary; | ||
| ``` | ||
| docker run --rm --name rn-build -v $PWD:/pwd -w /pwd gengjiawen/react-native /bin/sh -c "./gradlew installArchives" |
Contributor
There was a problem hiding this comment.
Change gengjiawen/react-native to reactnativecommunity/react-native-android
gengjiawen
reviewed
Dec 4, 2018
| ```$bash | ||
| # create .aar, then: | ||
| sed -i '' "s|^/android/||g" .gitignore | ||
| git add android |
Contributor
There was a problem hiding this comment.
Maybe just git add android --force.
Contributor
Author
|
@gengjiawen I've updated the PR for your comments. Can you clarify what you meant with add links to Docker website? I now added a single link to docker.com, but maybe you meant a specific page. |
Contributor
|
I think this will be good https://docs.docker.com/install/ |
Contributor
Author
|
@gengjiawen could you check the docker command is correct? I don't have it installed on this machine (disk space :P), so I wasn't able to run it yet. I think otherwise this PR is complete |
gengjiawen
approved these changes
Dec 9, 2018
Contributor
|
LGTM. Great work. |
Contributor
Author
|
@grabbou you mentioned you guys maintain a lot of forks at Callstack, would you mind having a quick look at this one? |
Contributor
|
Will look at it tomorrow, thanks for CCing us. |
Contributor
|
@facebook-github-bot shipit Our setup doesn't rely on Docker - I am taking @gengjiawen approval as a green light for this PR. Great job! And sorry for the lag, looks like Christmas break took longer than expected |
|
Deploy preview for react-native ready! Built with commit 39470a1 Changes to Thank you for your contributions. |
sunnylqm
referenced
this pull request
in reactnativecn/react-native-website
Feb 8, 2019
* [android] document required Network Security Config for React Native packager (#772) * add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs * add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs * Update navigation.md (#770) Use createAppContainer instead of createAppNavigator see function declaration here https://github.com/react-navigation/react-navigation/blob/master/src/react-navigation.js#L5 * Update README.md Fixed a few spelling errors in README.md * Deprecating NavigatorIOS (#776) * Deprecating NavigatorIOS * Remove navigator ios * Remove TabBarIOS, TabBarIOS.Item, NavigatorIOS from docs * Make Hello World prettier (#760) Fix #743 * Remove outdated Stetho documentation. * Fix Fresco docs link on the Image Style Props page (#783) * Remove CLI docs (#782) * Update scrollview.md to reflect duration argument (#115) * Update scrollview.md to reflect duration argument react/react-native#17422 adds the ability to control the duration of a scrollView animation, for Android only. * sync comments with ScrollView.js * add documentation about `.native.js` extensions (#346) * add documentation about `.native.js` extensions Lots of projects use the `.native.js` to share code between ReactJS and React Native (including core projects, like Jest) but there's no official documentation about it. I'm adding some info so projects can easily discover and refer to this feature. * fix comments and add pro-tip about `.native.js` Fixed the comment on a code block and added a pro-tip telling users to ignore `.native.js` extensions in their web bundlers in order to optimize final bundle size. * Update platform-specific-code.md * Link to all KeyboardType screenshots (#774) * Node version requirement made more prevalent (#775) Reading the first page of https://facebook.github.io/react-native/docs/getting-started.html, it is not clear that the node version needs to be 8+. Just adding this here to help others with installation, specially those of us who already have node running and need to upgrade. * Explicitly state that `activeOpacity` requires `underlayColor` (#781) * Explicitly state that `activeOpacity` requires `underlayColor` It's clear from react/react-native#11834 that the underlying issue won't be fixed, so we should update the documentation so people understand that for `activeOpacity` to work, they need to set `underlayColor`. * Update touchablehighlight.md * Add section : Known Issues with fetch and [..] (#769) * Add section : Known Issues with fetch and [..] Cookie based authentication is currently wobbly. Had it not been for the problematic redirect scenario using fetch workarounds could be found (e.g clearing cookies before every single request and manually adding them to the headers). However, because of the 302 issue there is a scenario where using cookies can result in halt of development. The rest of the issues are merely added here so that people that can follow workarounds ( please take a look as unintended consequences might occur ) * Minor text changes and remove the last paragraph. * Document how to publish custom React Native version (#675) * Add section for how to make a git dependency branch (#653) * move publishing a fork to separate page (#653) * updated review comments * link back from building android sources and updated docker link * changed to —force instead of changing .gitignore * Update publishing.md * Update correct signing information for iOS (#766) Ran into this problem while following this guide verbatim. * Update Wix link and title in showcast.json (#763) * change showcast wix logo app * fix file name * Update Wix link and title in showcast * Change wording to improve sentence (#759) * Text/TextInput: Android now supports `maxFontSizeMultiplier` prop (#755) Introduced by this commit: react/react-native@4936d28 * Fix typo (#738) * Fix typo * Update linking-libraries-ios.md * update to rn-diff-purge (#761) * Prettify * Sync guides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation page for #653 to the Android Building from Sources doc.