Skip to content

[docs] Create "Debugging Release Builds" guide, consolidate existing pages#3889

Merged
huntie merged 1 commit into
react:mainfrom
huntie:new-debugging-docs
Oct 19, 2023
Merged

[docs] Create "Debugging Release Builds" guide, consolidate existing pages#3889
huntie merged 1 commit into
react:mainfrom
huntie:new-debugging-docs

Conversation

@huntie

@huntie huntie commented Oct 18, 2023

Copy link
Copy Markdown
Member
  • Replaces the symbolication and sourcemaps pages with a new "Debugging Release Builds" guide, now located under Debugging. This minimally describes how to enable source maps and symbolicate release builds. Code references have been updated.
  • /docs/sourcemaps and /docs/symbolication are redirected to the new page.

@netlify

netlify Bot commented Oct 18, 2023

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 22628a1
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/65311ac99355e90009ced85a
😎 Deploy Preview https://deploy-preview-3889--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huntie
huntie force-pushed the new-debugging-docs branch from 527e284 to 5058c7e Compare October 18, 2023 15:38
Comment thread website/docusaurus.config.js Outdated
@huntie
huntie force-pushed the new-debugging-docs branch from 5058c7e to 6a09dab Compare October 18, 2023 15:44
@Simek

Simek commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

Thanks for updating the guides! 🙏 New content looks really nice, just have one nit about redirect.

Currently we use the static, serve side redirects for most of the moved pages:

If there is no strong reason why to use client side approach in those cases, we probably should stick to the solution above.

@huntie
huntie force-pushed the new-debugging-docs branch from 6a09dab to 2fe982c Compare October 19, 2023 11:11
@huntie

huntie commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

@Simek Thanks, was hoping we had something like that. Updated.

@huntie
huntie force-pushed the new-debugging-docs branch from 2fe982c to 22628a1 Compare October 19, 2023 12:02
@blakef

blakef commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

NITs:

  • normalise to stack trace not stacktrace,
  • source map doc (I know you didn't write this, but it'd be nice to tweak these):
    • would you fix the one dangling inconsitent use of "sourcemaps"
    • the language should be updated here to change decipherable to symoblicated (maybe with a link the symbolicated doc)?

@blakef blakef assigned blakef and unassigned blakef Oct 19, 2023
@blakef
blakef self-requested a review October 19, 2023 15:19
@huntie
huntie merged commit d872c42 into react:main Oct 19, 2023
@huntie
huntie deleted the new-debugging-docs branch October 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants