Skip to content

Update navigation.md to point to the documentation for the various navigation solutions for react-native#3866

Merged
cortinico merged 8 commits into
react:mainfrom
JuszJo:update-navigation-page
Oct 3, 2023
Merged

Update navigation.md to point to the documentation for the various navigation solutions for react-native#3866
cortinico merged 8 commits into
react:mainfrom
JuszJo:update-navigation-page

Conversation

@JuszJo

@JuszJo JuszJo commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

Update navigation.md to point to the documentation for the various navigation solutions for react-native.

Preview

preview (2)

@facebook-github-bot

Copy link
Copy Markdown

Hi @JuszJo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@JuszJo JuszJo changed the title Add missing config step for android devices in navigation.md #3862 Add missing config step for android devices in navigation.md Sep 30, 2023
@netlify

netlify Bot commented Sep 30, 2023

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 9d7eb22
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/651b307eda77a90008009ba5
😎 Deploy Preview https://deploy-preview-3866--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cortinico

Copy link
Copy Markdown
Contributor

See my comment here #3862 (comment)

@JuszJo JuszJo changed the title Add missing config step for android devices in navigation.md Update navigation.md to point to the documentation for the various navigation solutions for react-native Oct 2, 2023
@JuszJo

JuszJo commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

Hey @cortinico, I have updated the PR.

@cortinico
cortinico requested a review from cipolleschi October 2, 2023 21:28

@cipolleschi cipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JuszJo so much for taking care of this update! It will make our documentation much more maintainable.

@cortinico
cortinico merged commit c7d2045 into react:main Oct 3, 2023
@JuszJo

JuszJo commented Oct 3, 2023

Copy link
Copy Markdown
Contributor Author

@cipolleschi You're welcome, I am honored to have been given the opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants