feature: set fixed device types for Snack#3724
Merged
NickGerleman merged 3 commits intoMay 18, 2023
Merged
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cortinico
reviewed
May 17, 2023
NickGerleman
approved these changes
May 17, 2023
NickGerleman
left a comment
NickGerleman
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on ❤️. Next step for us will be to tweak that around with the fixed height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature, added in expo/snack#425 helps us avoid the issue reported by @NickGerleman in expo/snack#422.
With this, we (Expo) can update the devices without affecting the React Native docs. We may do this due to outdated visual appearances or OS versions. Only when updated here, and validated that it doesn't cut anything off, the React Native docs can be updated too.
The cutoff is caused by the height changes in the device preview, and can be controlled here: https://github.com/facebook/react-native-website/blob/d67805884a7c0920dcefc1af5894580984918239/website/src/css/customTheme.scss#L1717