Skip to content

Fix out-of-bounds iOS/Android emulators in examples #3751

Description

@NickGerleman

Some of the examples on the React Native documentation are missing part of their content when viewed on Android/iOS.

https://reactnative.dev/docs/image-style-props

image

image

This is because the website sets a fixed height for the player, and the rendering of the device we were showing has changed.

https://github.com/facebook/react-native-website/blob/d67805884a7c0920dcefc1af5894580984918239/website/src/css/customTheme.scss#L1717

@byCedric did great work in #3724 to allow the React Native website to customize the frame the emulator is shown in. We should leverage that, and change our styling + embed to a new value which avoids being cut off.

Metadata

Metadata

Assignees

No one assigned

    Labels

    👋 Good first issueInterested in collaborating? Take a stab at fixing one of these issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions