Guard against unmounted components when using traversal APIs#41451
Closed
rubennorte wants to merge 2 commits into
Closed
Guard against unmounted components when using traversal APIs#41451rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51210455 |
rubennorte
force-pushed
the
export-D51210455
branch
from
November 14, 2023 10:21
c6ec26b to
9bdbb0c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51210455 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51210455 |
rubennorte
force-pushed
the
export-D51210455
branch
2 times, most recently
from
November 14, 2023 13:06
7563a22 to
9690476
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51210455 |
… Fabric (#27687) (#41452) Summary: ## Summary This fixes an error in `getPublicInstanceFromInstanceHandle` where we throw an error when trying to access the public instance from the fiber of an unmounted component. This shouldn't throw but return `null` instead. ## How did you test this change? Updated unit tests. Before: <img width="969" alt="Screenshot 2023-11-10 at 15 26 14" src="https://github.com/facebook/react/assets/117921/ea161616-2775-4fab-8d74-da4bef48d09a"> After: <img width="1148" alt="Screenshot 2023-11-10 at 15 28 37" src="https://github.com/facebook/react/assets/117921/db18b918-b6b6-4925-9cfc-3b4b2f3ab92d"> DiffTrain build for commit react/react@6b3834a. Test Plan: Sandcastle tests Reviewed By: tyao1 Differential Revision: D51203276 Pulled By: tyao1
Summary: After [this change in React](react/react#27687), `ReactFabric.getPublicInstanceFromInternalInstanceHandle` can return `null` if the instance handle is a fiber that was unmounted (before that PR, it would throw an error). This modifies the DOM traversal API to gracefully handle that case. Changelog: [internal] Reviewed By: rshest Differential Revision: D51210455
rubennorte
force-pushed
the
export-D51210455
branch
from
November 14, 2023 13:26
9690476 to
004e290
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51210455 |
Contributor
|
This pull request has been merged in fc0c084. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After this change in React,
ReactFabric.getPublicInstanceFromInternalInstanceHandlecan returnnullif the instance handle is a fiber that was unmounted (before that PR, it would throw an error).This modifies the DOM traversal API to gracefully handle that case.
Changelog: [internal]
Reviewed By: rshest
Differential Revision: D51210455