Fix iOS Image.getSizeWithHeaders#29338
Closed
PaitoAnderson wants to merge 1 commit into
Closed
Conversation
Base commit: 120ff7c |
Base commit: 120ff7c |
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
Thanks for fixing this! |
Collaborator
|
This pull request was successfully merged by @PaitoAnderson in 0bcc686. When will my fix make it into a release? | Upcoming Releases |
Contributor
Author
|
@PeteTheHeat Thanks for merging 🇨🇦 |
tvand08
pushed a commit
to tvand08/react-native
that referenced
this pull request
Aug 11, 2020
Summary: Fixes react#28632 Image.getSizeWithHeaders() was not working as intended on iOS. ## Changelog [iOS] [Fixed] - Fixed headers in `Image.getSizeWithHeaders`. Pull Request resolved: react#29338 Test Plan: Used RNTester and an Image URL requiring a Bearer token to test. Code: <img width="720" alt="Screen Shot 2020-07-10 at 3 00 58 PM" src="https://user-images.githubusercontent.com/4108718/87189376-850cba00-c2be-11ea-851c-d9fa37d88de4.png"> With Bearer Token: <img width="456" alt="Screen Shot 2020-07-10 at 3 02 48 PM" src="https://user-images.githubusercontent.com/4108718/87189349-7de5ac00-c2be-11ea-8d82-c74cae6d904b.png"> Without Bearer Token: <img width="559" alt="Screen Shot 2020-07-10 at 3 04 32 PM" src="https://user-images.githubusercontent.com/4108718/87189458-aff70e00-c2be-11ea-82b7-34a14ec465f1.png"> Reviewed By: cpojer Differential Revision: D22783037 Pulled By: PeteTheHeat fbshipit-source-id: 3ad5026e71607c61d42316784844c5295bc1dcae
kelset
pushed a commit
that referenced
this pull request
Sep 29, 2020
Summary: Fixes #28632 Image.getSizeWithHeaders() was not working as intended on iOS. ## Changelog [iOS] [Fixed] - Fixed headers in `Image.getSizeWithHeaders`. Pull Request resolved: #29338 Test Plan: Used RNTester and an Image URL requiring a Bearer token to test. Code: <img width="720" alt="Screen Shot 2020-07-10 at 3 00 58 PM" src="https://user-images.githubusercontent.com/4108718/87189376-850cba00-c2be-11ea-851c-d9fa37d88de4.png"> With Bearer Token: <img width="456" alt="Screen Shot 2020-07-10 at 3 02 48 PM" src="https://user-images.githubusercontent.com/4108718/87189349-7de5ac00-c2be-11ea-8d82-c74cae6d904b.png"> Without Bearer Token: <img width="559" alt="Screen Shot 2020-07-10 at 3 04 32 PM" src="https://user-images.githubusercontent.com/4108718/87189458-aff70e00-c2be-11ea-82b7-34a14ec465f1.png"> Reviewed By: cpojer Differential Revision: D22783037 Pulled By: PeteTheHeat fbshipit-source-id: 3ad5026e71607c61d42316784844c5295bc1dcae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28632
Summary
Image.getSizeWithHeaders() was not working as intended on iOS.
Changelog
[iOS] [Fixed] - Fixed headers in
Image.getSizeWithHeaders.Test Plan
Used RNTester and an Image URL requiring a Bearer token to test.
Code:
With Bearer Token:
Without Bearer Token:
