Skip to content

Added instructions for setting up and running the examples within the re...#250

Closed
jondot wants to merge 2 commits into
react:masterfrom
jondot:master
Closed

Added instructions for setting up and running the examples within the re...#250
jondot wants to merge 2 commits into
react:masterfrom
jondot:master

Conversation

@jondot

@jondot jondot commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

...pository

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@jondot

jondot commented Mar 26, 2015

Copy link
Copy Markdown
Contributor Author

Just signed the CLA.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Comment thread docs/GettingStarted.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space

@amasad

amasad commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

good idea. Let's just remove extra spaces and happy to pull it

@jondot

jondot commented Mar 26, 2015

Copy link
Copy Markdown
Contributor Author

This good?

@amasad

amasad commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

Oh sorry, I thought this was an addition to this repo's readme. I don't think we should add more stuff to the getting started tutorial. It should be as small as possible.

However, I think this would be a great addition to this repo's readme. https://github.com/facebook/react-native/blob/master/README.md

@jondot

jondot commented Mar 26, 2015

Copy link
Copy Markdown
Contributor Author

Sure, I had the dilemma myself since I didn't see any concrete 'getting started' type wording there, I figured it belonged in the /docs folder. I'll add it as a separate pull request and then you can just close this one and accept the other one :)

@amasad

amasad commented Mar 30, 2015

Copy link
Copy Markdown
Contributor

Fixed via #267

@amasad amasad closed this Mar 30, 2015
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Feb 27, 2020
…_ptr` to match the change in `RCTCxxBridge.mm` made in react@71a8944. (react#250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants