Generated by 🚫 dangerJS

@vonovak Thanks for the PR! React Native supports BUCK on Android, this is the part of the build that fails. You will need to add the dependency to the BUCK file in the checkbox folder. You can probably have a look at another component that uses the support library to figure out what you need to add.

@janicduplessis thanks for the quick response, since I'm not experienced in using buck myself, I somehow ignored the buck files. the PR should be good for merge.

Looks good! I’ll check out your other PR too soon.

@facebook-github-bot shipit

Something went wrong executing that command, @hramos could you take a look?

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

Thanks for the contribution! It looks like I'll need to update some buck related files on our side before I can merge this. I'll add it to my task list. No further action is required on your part -- please do not add commits to this PR now that it has been approved as doing so may prevent it from getting merged.

Looked into this again, the actual error we're seeing is:

Warning: com.facebook.react.views.checkbox.ReactCheckBox: can't find referenced method 'boolean isChecked()' in program class com.facebook.react.views.checkbox.ReactCheckBox
Warning: com.facebook.react.views.checkbox.ReactCheckBoxManager: can't find referenced method 'void setOnCheckedChangeListener(android.widget.CompoundButton$OnCheckedChangeListener)' in program class com.facebook.react.views.checkbox.ReactCheckBox
Warning: com.facebook.react.views.checkbox.ReactCheckBoxManager: can't find referenced method 'void setEnabled(boolean)' in program class com.facebook.react.views.checkbox.ReactCheckBox
Warning: there were 3 unresolved references to program class members.

I need to get back to this again later.

@hramos Any update on this, could be related with the crazyness in https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/third-party/android/support/v7/appcompat-orig/BUCK. I'm not very familiar with BUCK so I can't really help here.

The error logs were cleared, so let's try importing again.