Add proptypes for scrollview drag start & end handlers#17368
Closed
ExplodingCabbage wants to merge 2 commits into
Closed
Add proptypes for scrollview drag start & end handlers#17368ExplodingCabbage wants to merge 2 commits into
ExplodingCabbage wants to merge 2 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Contributor
Author
|
Hmm. I see a test failure, but it looks unrelated to my change. Anyone able to help? |
Contributor
|
Looks good to me. It appears that these undocumented props were called by the ScrollResponder mixin: |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 28, 2017
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ScrollViewhas a bunch ofonFoohandlers for scrolling-related events, most of which have a proptype defined and are documented. However,onScrollBeginDragandonScrollEndDragdo not currently have a proptype and are not currently documented (as noted at https://stackoverflow.com/a/41793747/1709587). It seems reasonable to bring consistency and to provide documentation of these otherwise hard-to-discover props.Test Plan
I haven't added or run any tests, and don't plan to do so (beyond waiting and seeing that no existing checks fail in CircleCI).
Related PRs
I have also created a PR to update the documentation at react/react-native-website#99
Release Notes(None needed; this isn't a functionality change.)